Skip to content

made symlink check if the paths are correcly set to shared dir#1789

Open
sbAsma wants to merge 2 commits intoecmwf:developfrom
sbAsma:sbAsma/develop/1468-symlinks
Open

made symlink check if the paths are correcly set to shared dir#1789
sbAsma wants to merge 2 commits intoecmwf:developfrom
sbAsma:sbAsma/develop/1468-symlinks

Conversation

@sbAsma
Copy link
Contributor

@sbAsma sbAsma commented Feb 4, 2026

Description

Issue Number

Closes #1468
Closes #1779

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@grassesi grassesi marked this pull request as ready for review February 4, 2026 07:59
@grassesi grassesi mentioned this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

git import failing Check if symlinks point to the shared directory in when running scripts/actions create-links

1 participant