feat: add separateReadonlyFromDisabled config option#2532
Open
kchobantonov wants to merge 3 commits intoeclipsesource:masterfrom
Open
feat: add separateReadonlyFromDisabled config option#2532kchobantonov wants to merge 3 commits intoeclipsesource:masterfrom
kchobantonov wants to merge 3 commits intoeclipsesource:masterfrom
Conversation
Allows independent control of readonly and enabled states. Adds READONLY/WRITABLE rule effects. Backward compatible (default: false).
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
@sdirix @lucas-koehler please review - this provides the core and vue-vuetify implementation - the other renderers can be done separately |
lucas-koehler
requested changes
Feb 2, 2026
Contributor
lucas-koehler
left a comment
There was a problem hiding this comment.
Hi @kchobantonov , thanks for this contribution ❤️
The changes already look pretty good to me.
I have two points:
- The calculation
!control.enabled || control.readonlyis used in many renderers now. Could it make sense to extract a utility for this? - We should add unit tests for the following:
evalReadonly()functionhasReadonlyRule()functionisReadonly()functionisInherentlyReadonly()function- The new
separateReadonlyFromDisabledconfig option behavior inisInherentlyEnabled() - The new
READONLYandWRITABLErule effects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows independent control of readonly and enabled states. Adds READONLY/WRITABLE rule effects. Backward compatible (default: false).
fixes #2479