[444] - Replace ArrayList with custom implementation that overrides equals method#587
Open
iofit wants to merge 2 commits intoeclipsesource:masterfrom
Open
[444] - Replace ArrayList with custom implementation that overrides equals method#587iofit wants to merge 2 commits intoeclipsesource:masterfrom
iofit wants to merge 2 commits intoeclipsesource:masterfrom
Conversation
…ls method comparing only references and size
iofit
changed the title
iddeepak
reviewed
May 27, 2025
| * compare references and ranges. | ||
| * @param <E> – the type of elements in this list | ||
| */ | ||
| private static class SimpleArrayList<E> extends ArrayList<E> { |
There was a problem hiding this comment.
Why override equals here when it just mirrors ArrayList.equals? What benefit does this custom impl add?
RamsesAupart
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.