junit 6

[mehmet-karaman]

No description provided.

[github-actions]

Test Results

  6 457 files  + 1 606    6 457 suites  +1 606   3h 32m 3s ⏱️ + 1h 6m 29s
 43 234 tests  -      2   42 649 ✅  -      3    584 💤 ±  0  0 ❌ ±0  1 🔥 +1 
170 247 runs  +42 518  167 909 ✅ +41 933  2 337 💤 +584  0 ❌ ±0  1 🔥 +1 

For more details on these errors, see this check.

Results for commit 2473ee3. ± Comparison against base commit bc139e9.

This pull request removes 2 tests.

org.eclipse.xtext.validation.junit5.FileAwareTestLanguageValidationJunit5Test ‑ testWithJunit5_01
org.eclipse.xtext.validation.junit5.FileAwareTestLanguageValidationJunit5Test ‑ testWithJunit5_02

[mehmet-karaman]

Hello @cdietrich ,

I would like to upgrade xtext from junit 5 to junit 6 and I've stumbled over the org.eclipse.xtext.junit5.tests .. Is there a sense why its called junit5 ? Should I also upgrade this one? Would it be better to refactor the name to org.eclipse.xtext.junit.jupiter.tests?

Maybe you know what to do with the
<plugin> <groupId>org.eclipse.tycho</groupId> <artifactId>tycho-surefire-plugin</artifactId> <configuration> <providerHint>junit5</providerHint> </configuration> </plugin>

there is not junit6 providerHint. Is it better to remove the configuration?

Best regards
Mehmet

[cdietrich]

I don’t have cappa this week. I also want to get @szarnekow and @LorenzoBettini involve
It’s called junit 5 cause it tests junit 5

[cdietrich]

Ps is there a provider hint in a newer tycho version

I fear it won’t be possible to support 5 and 6 at the same time or do you

[cdietrich]

Maybe we also need to break everybody and remove junit 5 and 6 from the testing bundles and introduce dedicated ones

but as said I have no capacity to find out how junit 6 works and how it could be splitting

[cdietrich]

@mehmet-karaman @iloveeclipse maybe you can join one of our Xtext calls with @szarnekow and @LorenzoBettini and we can discuss this together with tycho 5 and Java 25

[LorenzoBettini]

Maybe there must be a hint similar to what we have now:

	<build>
		<plugins>
			<plugin>
				<groupId>org.eclipse.tycho</groupId>
				<artifactId>tycho-surefire-plugin</artifactId>
				<configuration>
					<providerHint>junit5</providerHint>
				</configuration>
			</plugin>
		</plugins>
	</build>

Otherwise, we could try to add back the JUnit5 classpath container that we removed previously, as it didn't work with Tycho. Maybe things have changed in that respect.

[mehmet-karaman]

@cdietrich When is the call?

[mehmet-karaman]

btw. @iloveeclipse said that we would like to join.

[cdietrich]

First one next year is on Jan 13 9am

[iloveeclipse]

First one next year is on Jan 13 9am

Can you send an invite to the meeting or point to any public calendar with the appointment?

[cdietrich]

@szarnekow cam you please do as you manage the meeting

[LorenzoBettini]

@szarnekow cam you please do as you manage the meeting

shall we skip the one scheduled for next Tuesday, 23rd December?

[cdietrich]

@LorenzoBettini i dont know if ill have sufficient infra next tuesday