remove x-internal for TextMate fragment

[asheiduk]

The TextMate generator fragment was introduced in 2.35. But to use it without provoking warnings in our code the x-internal marking should be removed. No other fragment seems to have this marker.

[github-actions]

Test Results

  6 461 files  ±0    6 461 suites  ±0   3h 19m 51s ⏱️ + 13m 22s
 43 236 tests ±0   42 652 ✅ ±0    584 💤 ±0  0 ❌ ±0 
170 255 runs  ±0  167 918 ✅ ±0  2 337 💤 ±0  0 ❌ ±0 

Results for commit 80a75b5. ± Comparison against base commit d90c452.

[cdietrich]

am not sure if @szarnekow had some reasoning behind this

[cdietrich]

@asheiduk can you please check your ECA status

[asheiduk]

@cdietrich Updated

[szarnekow]

am not sure if @szarnekow had some reasoning behind this

The reason was probably that it landed short before a release, and we didn't get a ton of feedback yet so no updates have been made.

If it works reasonably well, I'm absolutely fine with making it "public"

[asheiduk]

@szarnekow
Regarding the output: The resulting file does not work when trying to install it into Eclipse: Comparing with the example from
https://eclipse.dev/Xtext/documentation/340_lsp_support.html at least the section fileTypes is missing.

[cdietrich]

The eclipse help needs regular regeneration and I have no time to check where I still have a workspace with a working Jekyll stuff

[asheiduk]

@cdietrich : +Confused+ The Help is correct, the text generated by the fragment is missing fileTypes. Without that key I failed to install the TextMate grammar into Eclipse. With that key added manually it worked.

[cdietrich]

Ahhh am confused too . How do you register it to be eclipse ?

[asheiduk]

@cdietrich As explained in https://eclipse.dev/Xtext/documentation/340_lsp_support.html using only these steps:

• Define a content type/extension mapping as as explained in step 1)
• then import the generated/modified Json file as explained in step 4)

Before that I registered the fragment according as explained here: #1329 (comment)

[cdietrich]

I wonder when this broke. Need to check the old example if I came find it

[cdietrich]

nope here i had it from the beginning:
https://github.com/cdietrich/mydsl-lsp4e/blob/cdb0fe757262d105f05bd7eecdff836adf15deed/mydsl.lsp4e/syntaxes/mydsl.tmLanguage.json#L5

[asheiduk]

@cdietrich Regarding CLA: I have updated the CLA, checked there the link to my github account. what is missing?

[cdietrich]

i requested a revalidate.
what about the missing feature?