-
Notifications
You must be signed in to change notification settings - Fork 326
Add scrolling to AnnotationWithQuickFixesHover #3411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I haven't tried the PR, but don't the scrollbars automatically appear when you focus on the hover, e.g., with F2? Can you please post screenshots of the current situation and the changed behavior? |
|
@mehmet-karaman @iloveeclipse can you please also check this with your codebase |
|
on mac i have scrollbars without this patch but do not with this patch |
|
I am going to check that. |
|
I guess i understand what this change means: In normal mode the quickfix annotation hover didn't had a scrollbar. After the change it has a scrollbar.. (even if it wasn't necessary..). I've recorded a video from after change and before change.. Record.mp4 |
|
But to use the scrollbar (after the change), you have to focus on the popup, do you? |
|
no even on focus i dont see any Bildschirmaufnahme.2025-04-16.um.11.18.58.mov |
|
on main: Bildschirmaufnahme.2025-04-16.um.11.20.24.mov |
|
@LorenzoBettini |
|
So if I understand correctly, the PR does not provide additional utility and it breaks the existing behavior at least on mac. |
|
Why was it necessary to provide this fix? Was there a bug regarding this? I've never felt like it was defect.. Could it be that on windows it behaves different? |
|
so i guess we need a splution that works for both the area with the message and the area with the quickfixes |


Add scrolling to the hover in order to allow displaying of larger text in the error hover