Skip to content

Conversation

@MKamelEJ
Copy link

Add scrolling to the hover in order to allow displaying of larger text in the error hover

@LorenzoBettini
Copy link
Contributor

I haven't tried the PR, but don't the scrollbars automatically appear when you focus on the hover, e.g., with F2?

Can you please post screenshots of the current situation and the changed behavior?

@cdietrich
Copy link
Contributor

@mehmet-karaman @iloveeclipse can you please also check this with your codebase

@cdietrich
Copy link
Contributor

on mac i have scrollbars without this patch but do not with this patch

@github-actions
Copy link

Test Results

  6 452 files  ±0    6 452 suites  ±0   3h 0m 8s ⏱️ - 9m 44s
 43 189 tests ±0   42 605 ✅ ±0    584 💤 ±0  0 ❌ ±0 
169 807 runs  ±0  167 470 ✅ ±0  2 337 💤 ±0  0 ❌ ±0 

Results for commit 9de803f. ± Comparison against base commit 0ebaf43.

@mehmet-karaman
Copy link
Contributor

I am going to check that.

@mehmet-karaman
Copy link
Contributor

I guess i understand what this change means: In normal mode the quickfix annotation hover didn't had a scrollbar. After the change it has a scrollbar.. (even if it wasn't necessary..). I've recorded a video from after change and before change..

Record.mp4

@LorenzoBettini
Copy link
Contributor

But to use the scrollbar (after the change), you have to focus on the popup, do you?
When you focus, the scrollbar will appear anyway, won't it?

@cdietrich
Copy link
Contributor

no even on focus i dont see any

Bildschirmaufnahme.2025-04-16.um.11.18.58.mov

@cdietrich
Copy link
Contributor

on main:

Bildschirmaufnahme.2025-04-16.um.11.20.24.mov

@mehmet-karaman
Copy link
Contributor

mehmet-karaman commented Apr 16, 2025

@LorenzoBettini
Yes, If i click on the Toolbar, it behaves like I've pushed the F2 key.. But in my case I even didn't needed a Scrollbar.. The original space was enough.

@LorenzoBettini
Copy link
Contributor

So if I understand correctly, the PR does not provide additional utility and it breaks the existing behavior at least on mac.

@mehmet-karaman
Copy link
Contributor

Why was it necessary to provide this fix? Was there a bug regarding this? I've never felt like it was defect.. Could it be that on windows it behaves different?

@Abozekry
Copy link

I tried and it seems for large annotation text, user friendly scrolling is needed
Screenshot_before_For_Github
Screenshot_after_For_Github

@cdietrich
Copy link
Contributor

so i guess we need a splution that works for both the area with the message and the area with the quickfixes

@szarnekow
Copy link
Contributor

@Abozekry @MKamelEJ how shall we proceed with this? Do you plan to refine the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants