ci: pass Harbor secrets explicitly to reusable dockerbuild workflow so other organizations can re-use them#9
Closed
arnemileswinter wants to merge 1 commit into
Closed
Conversation
GitHub Actions secrets:inherit does not propagate across different owners. Add explicit HARBOR_HOST and HARBOR_CREDENTIALS mapping to both dockerbuild jobs so secrets are forwarded once upstream declares them in on.workflow_call.secrets. Signed-off-by: Arne Winter <a.winter@neusta.de>
|
Contributor
|
I can't merge this, because it's required then to add in hundreds of workflows the secrets first:) propose an optional solution please |
Contributor
|
try this please: #10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the same docker workflow work from forks. Before, the workflow was not able to access secrets from other organizations. We need to be explicit about secrets.
Before, the workflow would complain, as per this example run: