[GEF] Fully migrate to the GEF TreeViewer#1432
Draft
ptziegler wants to merge 1 commit intoeclipse-windowbuilder:masterfrom
Draft
[GEF] Fully migrate to the GEF TreeViewer#1432ptziegler wants to merge 1 commit intoeclipse-windowbuilder:masterfrom
ptziegler wants to merge 1 commit intoeclipse-windowbuilder:masterfrom
Conversation
Test Results 1 360 files - 1 360 1 360 suites - 1 360 6h 50m 41s ⏱️ - 5h 41m 44s For more details on these failures and errors, see this check. Results for commit 957cef8. ± Comparison against base commit 56b01bd. ♻️ This comment has been updated with latest results. |
ptziegler
force-pushed
the
gef-tree-viewer
branch
2 times, most recently
from
428b2d3 to
25d857a
Compare
This removes our copy of the `TreeViewerEditPart` and `TreeViewer` in favor of the upstream classes. In order to use the GEF viewer directly, a virtual `DesignComponent` edit part needs to be used as contents, holding the `Tree` widget. Otherwise the edit part of the first model is not shown.
ptziegler
force-pushed
the
gef-tree-viewer
branch
from
25d857a to
957cef8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes our copy of the
TreeViewerEditPartandTreeViewerin favor of the upstream classes. In order to use the GEF viewer directly, a virtualDesignComponentedit part needs to be used as contents, holding theTreewidget. Otherwise the edit part of the first model is not shown.