Skip to content

Comments

Timesync#7

Merged
schandrika merged 15 commits intoeclipse-volttron:developfrom
davidraker:timesync
Feb 13, 2026
Merged

Timesync#7
schandrika merged 15 commits intoeclipse-volttron:developfrom
davidraker:timesync

Conversation

@davidraker
Copy link
Contributor

This pull request introduces several improvements and refactors to the BACnet protocol proxy library, focusing on standardizing interface naming, enhancing time synchronization support, improving error handling, and updating documentation. The changes also include minor code cleanups and dependency updates.

Key changes include:

Interface and Argument Standardization

  • Standardized argument names from local_device_address/bacnet_network to local_interface/bacnet_port across BACnet, BACnetProxy, and related functions, improving clarity and consistency throughout the codebase. [1] [2] [3]

Time Synchronization Enhancements

  • Added a new endpoint and support for periodic BACnet device time synchronization, allowing scheduled updates with timezone awareness using ZoneInfo and timedelta. This includes the ability to start and stop synchronization tasks dynamically.

Error Handling and Logging Improvements

  • Improved error handling in batch and property read/write operations, including better exception catching and logging, and returning errors directly from write operations. [1] [2] [3]
  • Updated logging for device discovery to use info level and cleaned up excessive debug logs. [1] [2]

API and Serialization Updates

  • Added support for serializing BinaryPV values as integers for backward compatibility in JSON responses. [1] [2]
  • Minor fixes to endpoint argument names and improved cache stats endpoint signature.

Documentation and Dependency Updates

  • Major update to README.md with new badges, installation instructions, and project description.
  • Updated pyproject.toml to add a [tool.poetry.group.dev.dependencies] section for clarity.
  • Added missing imports for timezone support.

These changes collectively improve code maintainability, usability, and reliability for users integrating BACnet devices via the protocol proxy.


References: [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]

@schandrika schandrika merged commit f12a347 into eclipse-volttron:develop Feb 13, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants