Conversation
…changes' into merge_of_rileys_code_and_latest_changes
…t on each device.
…ompatibility with old driver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors to the BACnet protocol proxy library, focusing on standardizing interface naming, enhancing time synchronization support, improving error handling, and updating documentation. The changes also include minor code cleanups and dependency updates.
Key changes include:
Interface and Argument Standardization
local_device_address/bacnet_networktolocal_interface/bacnet_portacrossBACnet,BACnetProxy, and related functions, improving clarity and consistency throughout the codebase. [1] [2] [3]Time Synchronization Enhancements
ZoneInfoandtimedelta. This includes the ability to start and stop synchronization tasks dynamically.Error Handling and Logging Improvements
API and Serialization Updates
BinaryPVvalues as integers for backward compatibility in JSON responses. [1] [2]Documentation and Dependency Updates
README.mdwith new badges, installation instructions, and project description.pyproject.tomlto add a[tool.poetry.group.dev.dependencies]section for clarity.These changes collectively improve code maintainability, usability, and reliability for users integrating BACnet devices via the protocol proxy.
References: [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]