Merge of rileys code and latest changes#6
Open
riley206-pnnl wants to merge 17 commits intoeclipse-volttron:developfrom
Open
Merge of rileys code and latest changes#6riley206-pnnl wants to merge 17 commits intoeclipse-volttron:developfrom
riley206-pnnl wants to merge 17 commits intoeclipse-volttron:developfrom
Conversation
…changes' into merge_of_rileys_code_and_latest_changes
There was a problem hiding this comment.
Pull Request Overview
This pull request modernizes the BACnet protocol proxy library by migrating from BACpypes v2 to BACpypes3, introducing new utility scripts for device discovery and configuration management, and improving documentation and project configuration.
Key Changes:
- Migrated three utility scripts (bacnet_scan.py, grab_bacnet_config.py, grab_multiple_configs.py) to use BACpypes3 with asyncio while maintaining backward compatibility with legacy BACpypes.ini configuration files
- Fixed error handling in bacnet.py to return error objects instead of only logging them
- Expanded README with installation instructions, dependency information, and project badges
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 25 comments.
Show a summary per file
| File | Description |
|---|---|
| src/protocol_proxy/protocol/bacnet/bacnet_proxy.py | Removed unused apdu_timeout parameter from who_is_endpoint method |
| src/protocol_proxy/protocol/bacnet/bacnet.py | Modified write_property to return error object on exception instead of just logging |
| scripts/grab_multiple_configs.py | New batch configuration scraper supporting CSV input for multiple BACnet devices |
| scripts/grab_bacnet_config.py | New device configuration scraper using BACpypes3 with INI file backward compatibility |
| scripts/bacnet_scan.py | New network scanner using BACpypes3 with device discovery and CSV export capabilities |
| scripts/BACpypes.ini | Sample configuration file for backward compatibility with legacy workflows |
| pyproject.toml | Fixed mypy python_version to use string format and added dev dependencies section |
| README.md | Expanded with installation instructions, dependencies, badges, and project information |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… functions and update entry points
…between 3.10 and 4.0
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Most of those are gone now since I removed the scripts. |
Contributor
Author
|
this should be ready to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and new features to the BACnet protocol proxy library, focusing on developer experience, backward compatibility, and improved tooling for BACnet device discovery and configuration. The most significant changes include the addition of new utility scripts for device scanning and batch configuration, improvements to documentation and packaging, and minor bug fixes.
New BACnet utility scripts:
scripts/bacnet_scan.py, a modernized BACnet network scanner using BACpypes3 and asyncio, supporting both legacy and new argument styles, INI file compatibility, device discovery, and CSV export.scripts/grab_multiple_configs.py, a batch utility for scraping configuration from multiple BACnet devices using a CSV input, compatible with both legacy and current workflows.BACpypes.iniconfiguration file for easier setup and compatibility with the new scripts.Documentation and packaging improvements:
README.mdwith installation instructions, dependency listing, usage notes, and project badges for Python versions and CI status.pyproject.tomlto clarify Python version specification for mypy, add a placeholder for development dependencies, and ensure accurate dependency management. [1] [2]Bug fixes and code quality:
bacnet.pywhere errors during property writes now return the error object instead of just logging it, improving error handling for clients.