Fix HybridJacksonPool stack node publication race#6112
Merged
tsegismont merged 1 commit intoMay 13, 2026
Conversation
tsegismont
approved these changes
May 13, 2026
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
LGTM, thank you @dreamlike-ocean !
This was referenced May 13, 2026
tsegismont
added a commit
that referenced
this pull request
May 13, 2026
tsegismont
added a commit
that referenced
this pull request
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Fixes a race in
HybridJacksonPool.StripedLockFreePool#releasePooled. #6111The virtual-thread pool was publishing a newly created stack node with CAS before assigning its
nextpointer. A concurrent acquire could observe and pop that partially initialized node, seenext == null, and drop the rest of the stack.This change initializes
newHead.nextbefore the CAS, so the node is fully linked before it becomes visible to other threads.Conformance:
I have signed the Eclipse Contributor Agreemen