Skip to content

CX-128 DCM update to incorporate changes from standard update#1416

Merged
stephanbcbauer merged 31 commits into
eclipse-tractusx:mainfrom
tobzahn:patch-4
Mar 10, 2026
Merged

CX-128 DCM update to incorporate changes from standard update#1416
stephanbcbauer merged 31 commits into
eclipse-tractusx:mainfrom
tobzahn:patch-4

Conversation

@tobzahn
Copy link
Copy Markdown
Contributor

@tobzahn tobzahn commented Jan 12, 2026

Description

This PR updates the DCM (CX-128) KIT to be reflect the changes from version 2.3 of the standard.
More information on how to handle specific n-tier scenarios is included in the KIT with this change.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@stephanbcbauer stephanbcbauer added the KIT KIT related content, mapped to TRactus-X releases label Jan 23, 2026
@stephanbcbauer stephanbcbauer added this to the 26.03 milestone Jan 23, 2026
terminology was updated
text added
table Access and Usage Policies updated
Reference to standard updated
Customer Location added in WeekBasedCapacityGroup properties
@LukasSchmetz LukasSchmetz self-requested a review February 6, 2026 08:15
lanfrans and others added 3 commits February 6, 2026 14:07
added paraamter table for Material Demand
URI in URL amended
Copy link
Copy Markdown
Contributor

@lanfrans lanfrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me

@LukasSchmetz LukasSchmetz requested review from MWADCM and jschu1 February 6, 2026 14:28
@Frank-Globisch
Copy link
Copy Markdown
Contributor

@tobzahn thanks for your invitation, for whatever reason I still cannot add myself as reviewer... not sure if it is a local issue that will be resolved after the week-end reboot (though I doubt it) ...

@MWADCM
Copy link
Copy Markdown

MWADCM commented Feb 6, 2026

Basically I agree. Nevertheless we have to take care for dependencies to Standard of BPDM CX-0010 & CX-076 since n-tier Standard will be affected by BPDM Process vv. Also cosidering "managed by concept"

Copy link
Copy Markdown

@MWADCM MWADCM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically I agree. Nevertheless we have to take care for dependencies to Standard of BPDM CX-0010 & CX-076 since n-tier Standard will be affected by BPDM Process vv. Also cosidering "managed by concept"

@reginePrivat reginePrivat self-requested a review February 11, 2026 07:46
@Frank-Globisch Frank-Globisch self-requested a review February 11, 2026 14:29
@tobzahn tobzahn mentioned this pull request Feb 13, 2026
Copy link
Copy Markdown
Contributor

@reginePrivat reginePrivat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Admin is only business partner internal person and nobody in the role of an admin configures the RfU itself
@stephanbcbauer
Copy link
Copy Markdown
Member

@tobzahn just because i am curious, :) Did CoPilot help? So are these found issues "real" issues/fixes? Or does it just confuse everybody?

I think it was helpful. Good idea to use this. Copilot suggested several corrections for typos and it is very convenient that you can just accept them. I am still impressed that it also suggested to use other words or even terminology changes like the leftOperand / left operand comment. Copilot was absolutely correct that this is misleading. So yes, this is helpful.

By the way: you asked to increase the version number, but I am not sure how and where KIT versions are controlled. I would likely increase the minor version.

Cool thx for the feedback -> you should adapt the changelog.md in your Kit. increase the version and describe what has been changed. This is for documentation.

And technical (filter in the UI, nice view) you have to adapt data/kitData.jsyou will find the DCM somewhere and there you can adapt the Version. -> description about this file

And if you are really motivated, here is another issue -> some broken links in your KIT

@tobzahn
Copy link
Copy Markdown
Contributor Author

tobzahn commented Mar 3, 2026

you should adapt the changelog.md in your Kit. increase the version and describe what has been changed. This is for documentation.

Done with [cde198b].

And technical (filter in the UI, nice view) you have to adapt data/kitData.jsyou will find the DCM somewhere and there you can adapt the Version. -> description about this file

Done with [c2901ce].

Copy link
Copy Markdown
Contributor

@matbmoser matbmoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some questions still

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has someone already checked if this looks good after compiled?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matbmoser @stephanbcbauer @Grand-Thibault Anything missing after the fixes @tobzahn did?

@matbmoser matbmoser self-requested a review March 4, 2026 09:29
@matbmoser matbmoser added question Further information is requested blocked PR is blocked because of a reason (specify with another label), and can't be merged labels Mar 4, 2026
@matbmoser matbmoser moved this from Todo to In Progress in KIT Office Hour Mar 4, 2026
@matbmoser matbmoser removed question Further information is requested blocked PR is blocked because of a reason (specify with another label), and can't be merged labels Mar 8, 2026
@matbmoser
Copy link
Copy Markdown
Contributor

Has someone updated the changelog here? It looks for me that is not.
And also make sure you are synced with main, because the changes were done a long time ago. Maybe it syncs automatically when merging to main.

@matbmoser matbmoser dismissed their stale review March 8, 2026 23:58

I dismiss my own review

@matbmoser
Copy link
Copy Markdown
Contributor

So @stephanbcbauer you can approve it if you want, was not really involved on the review here. at least removed the blocker.

Copy link
Copy Markdown
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Tractus-X Webpage Mar 10, 2026
@stephanbcbauer stephanbcbauer merged commit fb35fd8 into eclipse-tractusx:main Mar 10, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Tractus-X Webpage Mar 10, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Done in KIT Office Hour Mar 10, 2026
@tobzahn tobzahn deleted the patch-4 branch March 10, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

KIT KIT related content, mapped to TRactus-X releases

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.