Skip to content

[2289] Fix expression support for TransitionUsage#2296

Open
pcdavid wants to merge 2 commits into
mainfrom
pcd/fix/transition-guard
Open

[2289] Fix expression support for TransitionUsage#2296
pcdavid wants to merge 2 commits into
mainfrom
pcd/fix/transition-guard

Conversation

@pcdavid

@pcdavid pcdavid commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Bug: #2289
Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@pcdavid pcdavid added this to the 2026.7.0 milestone Jun 22, 2026
@pcdavid pcdavid linked an issue Jun 22, 2026 that may be closed by this pull request
@pcdavid pcdavid force-pushed the pcd/fix/transition-guard branch from 8a3ada2 to 3b4dc81 Compare June 22, 2026 13:54
@pcdavid pcdavid marked this pull request as ready for review June 22, 2026 13:54
@pcdavid pcdavid force-pushed the pcd/fix/transition-guard branch from 3b4dc81 to 081f34a Compare June 22, 2026 13:55
Bug: #2289
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid force-pushed the pcd/fix/transition-guard branch 2 times, most recently from f210c19 to 36af909 Compare June 22, 2026 15:17
…ring

- Share common code in the backend.
- Produce an actual Label widget instead of a Textfield as this is how
  we render it now.
- Simplify the frontend component to be closer to the
  LabelWidgetPropertySection instead of the more complex
  TextfieldPropertySection.

Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid force-pushed the pcd/fix/transition-guard branch from 36af909 to 7f5e648 Compare June 22, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix expression support for TransitionUsage

2 participants