[1945] Add ends compartment on ConnectionDef and AllocationDef graphical nodes#1974
Open
[1945] Add ends compartment on ConnectionDef and AllocationDef graphical nodes#1974
Conversation
pcdavid
force-pushed
the
pcd/enh/connection-def-ends-compartment
branch
from
880dc0a to
0e8d6ae
Compare
AxelRICHARD
added
pr: to review later
priority: low
priority: high
and removed
priority: low
labels
pcdavid
force-pushed
the
pcd/enh/connection-def-ends-compartment
branch
2 times, most recently
from
4d31268 to
79933b9
Compare
pcdavid
changed the title
pcdavid
force-pushed
the
pcd/enh/connection-def-ends-compartment
branch
from
79933b9 to
fe14086
Compare
pcdavid
commented
Feb 12, 2026
...vices/src/main/java/org/eclipse/syson/sysml/metamodel/services/ElementInitializerSwitch.java
Show resolved
Hide resolved
AxelRICHARD
reviewed
Feb 12, 2026
| @@ -63,10 +63,31 @@ public DiagramCheckerService(DiagramComparator diagramComparator, IDescriptionNa | |||
| */ | |||
| public Consumer<Object> childNodeGraphicalChecker(AtomicReference<Diagram> previousDiagram, DiagramDescriptionIdProvider diagramDescriptionIdProvider, String parentLabel, EClass childEClass, | |||
Member
There was a problem hiding this comment.
this method seems to be used only one time in the code, so may be you could only have the new version and delete this one?
|
|
||
| private void addConnectionEnd(ConnectionDefinition connectionDefinition, String name) { | ||
| var referenceUsage = SysmlFactory.eINSTANCE.createReferenceUsage(); | ||
| referenceUsage.setDeclaredName("end"); |
Member
There was a problem hiding this comment.
you should probably call "ElementInitializerSwitch" on the new elements you create
Contributor
Author
There was a problem hiding this comment.
Done, I think (not sure I understood correctly).
| ** Add _New Satisfy Requirement_ graphical edge tool between `Feature` graphical nodes and `RequirementUsage` graphical nodes. | ||
| This tool allows to create a `SatisfyRequirementUsage` between the `Feature` and `RequirementUsage` selected during the tool creation. | ||
|
|
||
| ** Newly created `AllocationDefinition` and `ConnectionDefinition` nodes now have two initial _connection ends_, named `source` and `target`. |
Member
There was a problem hiding this comment.
Please prefer graphical nodes instead of nodes and graphical edges instead of edges
…al nodes Bug: #1945 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
force-pushed
the
pcd/enh/connection-def-ends-compartment
branch
from
fe14086 to
b10d28c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: #1945
Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests