Open
Conversation
Contributor
|
@fprezado, thanks for contribution. Besides the implementations, I noticed there's no tests covering the new changes, this may be hard for us the maintain and prevent regressions. Can you fill in the test gaps? |
Author
Thanks for the review @msftcoderdjw . sure thing. let me add tests and come back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compliance or regulatory requirements mandate it, or to strengthen security through mutual authentication and encrypted communication between the Symphony MQTT provider and MQTT brokers, mTLS can be enabled by setting the useTLS configuration property in the Symphony configuration file and specifying the paths to the relevant certificates. For development or testing where certificate verification may not be possible, the insecureSkipVerify option can be set to true (this is not recommended for production use).
TLS/Certificate settings:
Example configuration for symphony mqtt provider client certificate authentication:
{
"brokerAddress": "ssl://mqtt.example.com:8883",
"clientID": "symphony-client",
"requestTopic": "symphony_request",
"responseTopic": "symphony_response",
"useTLS": "true",
"caCertPath": "/path/to/ca.crt",
"clientCertPath": "/path/to/client.crt",
"clientKeyPath": "/path/to/client.key"
}