Snapshots feature refactor#292
Open
AnnaPaolaMusio wants to merge 8 commits into
Open
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
umaucher
reviewed
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C++ implementation of the KVS module has been modified in terms of snapshot behavior.
Removal of
snapshot_rotateThe
snapshot_rotatefunction has been completely removed from the C++ implementation. Snapshot management is no longer automatic and requires an explicit call to the snapshot_create() function.The
flush()function no longer automatically creates snapshots.In the previous behavior (still valid for RUST)
flush()persisted the data and calledsnapshot_rotate()to automatically create a new snapshot. Nowflush()now only persists the current state of the KVS to disk.Implementation of snapshot_create API
The new snapshot_create() function has been implemented, allowing for the explicit creation of snapshots in the first available slot.
Implementation of snapshot_delete API
The snapshot_delete() function has been implemented to explicitly remove a specific snapshots by ID.
Update to snapshot_count and snapshot_restore.
A new component requirement has been introduced, according to the new behaviour of the snapshot_create.