Fixes persistency test_scenarios integration in reference_integration #228
+34
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
10 tasks
rmaddikery
force-pushed
the
rama_fix_logging_deps
branch
4 times, most recently
from
f3a9506 to
596a4f2
Compare
|
The created documentation from the pull request is available at: docu-html |
rmaddikery
changed the title
rmaddikery
force-pushed
the
rama_fix_logging_deps
branch
2 times, most recently
from
3eb6366 to
43d3910
Compare
rmaddikery
force-pushed
the
rama_fix_logging_deps
branch
from
73648e6 to
d1ad72d
Compare
rmaddikery
force-pushed
the
rama_fix_logging_deps
branch
2 times, most recently
from
0bceb88 to
cdc65a7
Compare
- library targets should depend on the log frontend to limit lib dep footprint. - while test targets need to proivide concrete backends. For unit tests a lightweight console recorder with console logging backend is sufficient. - for a binary target a log target that includes all backends is ideal.
- v2.0.0 is not compatible with bazel v8 and earlier - Issue filed: github.com/aspect-build/rules_lint/issues/759
rmaddikery
force-pushed
the
rama_fix_logging_deps
branch
from
cdc65a7 to
c26079f
Compare
FScholPer
approved these changes
Feb 12, 2026
vinodreddy-g
requested changes
Feb 12, 2026
|
|
||
| # ToDo: implicit dependencies for score_tooling, but needed directly here?? | ||
| bazel_dep(name = "aspect_rules_lint", version = "2.0.0") | ||
| bazel_dep(name = "aspect_rules_lint", version = "1.10.2") |
Contributor
There was a problem hiding this comment.
why was the version downgraded?
|
|
||
| # Override score_docs_as_code to resolve compatibility level conflicts between dependencies | ||
| bazel_dep(name = "score_docs_as_code", version = "3.0.0", dev_dependency = True) | ||
| single_version_override( |
Contributor
There was a problem hiding this comment.
why do we need single_version_override here?
Contributor
There was a problem hiding this comment.
moreover it cannot be used. The only place where it should be used is reference_integration repo
| visibility = ["//visibility:public"], | ||
| deps = [ | ||
| "//src/cpp/src:kvs_cpp", | ||
| "@score_logging//score/mw/log", |
Contributor
There was a problem hiding this comment.
why is this required for test_scenarios ? I dont see any tests added . It is becuase the kremotelogging=false is removed?
PiotrKorkus
reviewed
Feb 12, 2026
| ) | ||
|
|
||
| # TRLC required transitively via: score_logging -> score_communication -> trlc | ||
| bazel_dep(name = "trlc", version = "0.0.0") |
Contributor
There was a problem hiding this comment.
dev_dependency? I dont want every repo that uses persistency to be obliged to load trlc especially when it is not using it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes persistency test_scenarios integration in reference_integration as a prerequisite to integrate datarouter to the reference integration platform
Refer: eclipse-score/reference_integration#79
NOTE:
mw/log frontend is part of the https://github.com/eclipse-score/baselibs repo
mw/log recorders and respective concrete backends are part of https://github.com/eclipse-score/logging repo
That said, the mw/log:log target is no longer supported in the baselibs and requires to be fixed.
See: https://github.com/eclipse-score/baselibs/blob/381dd9a9c9c516d87b0840f61618ba9e668dabd5/score/mw/log/BUILD#L25
In order to integrate datarouter to the reference integration platform, the deps in image need to be fixed as a prerequisite.
TRLC dep could be excluded via:
The CI build jobs will be fixed after eclipse-score/communication#143
But it might be useful to retain incase tests or implementations in persistency repo need to refer AoUs and requirements coming from baselibs and logging repo.