testing: Unify component integration tests structure by igorostrowskiq · Pull Request #199 · eclipse-score/persistency

igorostrowskiq · 2025-12-16T16:34:00Z

No description provided.

github-actions · 2025-12-16T16:34:56Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: fa50008f-dbf5-470b-b62d-2b49a5c881b5
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-oEubHgeZDdT0svMmBKJx7c3/2TdSI/vfwRUyDn+TPGA="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_process', the root module requires module version score_process@1.3.2, but got score_process@1.4.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)

Analyzing: target //:license-check (35 packages loaded, 10 targets configured)

Analyzing: target //:license-check (83 packages loaded, 10 targets configured)

Analyzing: target //:license-check (87 packages loaded, 10 targets configured)

Analyzing: target //:license-check (147 packages loaded, 1178 targets configured)

Analyzing: target //:license-check (151 packages loaded, 2704 targets configured)

Analyzing: target //:license-check (156 packages loaded, 2727 targets configured)

Analyzing: target //:license-check (156 packages loaded, 2727 targets configured)

Analyzing: target //:license-check (156 packages loaded, 2727 targets configured)

Analyzing: target //:license-check (159 packages loaded, 4453 targets configured)

Analyzing: target //:license-check (161 packages loaded, 7422 targets configured)

INFO: Analyzed target //:license-check (162 packages loaded, 9013 targets configured).
[3 / 14] [Prepa] Creating source manifest for @@score_tooling+//dash/tool/formatters:dash_format_converter [for tool] ... (2 actions, 0 running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 62 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 39.197s, Critical Path: 0.31s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2025-12-16T16:36:59Z

The created documentation from the pull request is available at: docu-html

Copilot

Pull request overview

This PR standardizes the naming and structure of component integration tests across the repository. The main changes include:

Renaming test directories from language-prefixed names (rust_test_scenarios, cpp_test_scenarios, python_test_cases) to a unified structure under tests/test_scenarios/{language} and tests/test_cases
Updating all build files, configuration files, and documentation to reference the new paths
Removing language prefixes from binary and package names for consistency

Reviewed changes

Copilot reviewed 16 out of 41 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/test_scenarios/rust/Cargo.toml	Renamed package from `rust_test_scenarios` to `test_scenarios`
tests/test_scenarios/rust/BUILD	Updated binary name and visibility path to reflect new directory structure
tests/test_scenarios/cpp/src/test_basic.cpp	Updated namespace reference and reformatted braces (Allman style)
tests/test_scenarios/cpp/BUILD	Renamed binary from `cpp_test_scenarios` to `test_scenarios`
tests/test_cases/tests/conftest.py	Updated default target paths to new directory structure
tests/test_cases/requirements.txt.orig	Contains unresolved merge conflict markers
tests/test_cases/pyproject.toml	Renamed project from `python_test_cases` to `test_cases`
tests/test_cases/BUILD	Updated all target paths and comments to reference new structure
tests/integration_test_scenarios/init_rpi4.build	Updated commented path for QNX rust scenarios
tests/integration_test_scenarios/BUILD	Updated commented paths for QNX rust scenarios
tests/README.md	Updated all documentation paths and commands to reflect new structure
src/cpp/src/BUILD	Updated visibility path for test scenarios
MODULE.bazel	Updated requirements lock file path
Cargo.toml	Updated workspace member path
BUILD	Updated test suite target paths
.github/workflows/component_integration_tests.yml	Updated all workflow paths to new structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/test_cases/requirements.txt.orig

tests/README.md

Copilot

Pull request overview

Copilot reviewed 15 out of 40 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/test_cases/pyproject.toml

PiotrKorkus · 2025-12-16T20:58:17Z

tests/test_cases/pytest.ini

imho, PYTHONPATH should be added and . removed from import statements in test files

.github/workflows/component_integration_tests.yml

pyproject.toml

.github/workflows/component_integration_tests.yml

PiotrKorkus

lgtm

igorostrowskiq · 2025-12-19T13:48:23Z

Squashed commits

arkjedrz · 2026-01-09T17:10:23Z

pyproject.toml

Will similar changes be introduced to other repositories? Or is it per-repo?

its already on mains in kyron and ref_int

arkjedrz · 2026-01-09T17:10:40Z

tools/qnx_credential_helper.py

Should pyproject.toml that's inherently for tests cause formatting changes for a script?

pyproject.toml is centralized python config file so it will influence any python files. We can exclude scripts directory if we want it to be only for tests.

arkjedrz · 2026-01-09T17:15:12Z

tests/test_cases/tests/conftest.py

            bazel_tools = BazelTools(option_prefix="cpp", build_timeout=build_timeout)
            cpp_target_name = session.config.getoption("--cpp-target-name")
-            bazel_tools.build(cpp_target_name)
+            bazel_tools.build(cpp_target_name, "--config=per-x86_64-linux")


Is this a related change? What happened here?

For some time now building cpp version of kvs needs config to be passed. It has been fixed in CICD executions but in order to make python -m pytest --build-scenarios work this change is needed.

arkjedrz · 2026-01-09T17:18:34Z

pyproject.toml

+    "venv",
+]
+
+line-length = 120


This change is perfectly fine for me! I'd prefer having such change in a separate PR though, if possible.

Ok, I can remove all ruff related stuff from pyproject.toml and move it to separate PR. This way I will keep only pytest configs in this PR.

PR with ruff: #213

arkjedrz · 2026-01-09T17:19:55Z

tests/test_cases/requirements.txt

 pytest-metadata
 pytest-env
-testing-utils @ git+https://github.com/eclipse-score/testing_tools.git@v0.3.0
+testing-utils @ git+https://github.com/eclipse-score/testing_tools.git@675395d4088c8eba708e21d9e5c4efbc75f6a6b0


Replace with new version?

needed changes are not included in newest release yet

Why and what are those changes?

eclipse-score/testing_tools#14

enables passing extra options to bazel build - allows flag --build-scenarios to use necessary config

arkjedrz · 2026-01-09T17:20:24Z

tests/test_scenarios/cpp/src/test_basic.cpp

Unnecessary reformat.

arkjedrz · 2026-01-19T12:53:30Z

tests/test_cases/requirements.txt

 pytest-metadata
 pytest-env
-testing-utils @ git+https://github.com/eclipse-score/testing_tools.git@v0.3.0
+testing-utils @ git+https://github.com/eclipse-score/testing_tools.git@675395d4088c8eba708e21d9e5c4efbc75f6a6b0


Why and what are those changes?

arkjedrz · 2026-01-19T12:54:27Z

tests/test_cases/requirements.txt.lock

I'm not convinced this file should be part of the repo. Notice that paths are local machine dependent. This file will contribute to a noise on every change.

The file itself is needed. You can find it e.g. in docs-as-code https://github.com/eclipse-score/docs-as-code/blob/main/src/requirements.txt (they use .in and .txt, we use .txt and .txt.lock)

Local paths are inserted when automatically generating file with bazel command. Let me check if infra team how to make it look cleaner as in docs-as-code

edit: There is no way to generate this file without local paths in comments. The only way is to manually clean it up before committing.

…unify_cit_structure testing: Unify component integration tests structure

igorostrowskiq requested a review from Copilot December 16, 2025 16:34

igorostrowskiq force-pushed the igorostrowskiq_unify_cit_structure branch from 3e28bc9 to 9b6691f Compare December 16, 2025 16:44

igorostrowskiq requested a review from PiotrKorkus December 16, 2025 16:51

Copilot AI reviewed Dec 16, 2025

View reviewed changes

tests/test_cases/requirements.txt.orig Outdated Show resolved Hide resolved

tests/README.md Outdated Show resolved Hide resolved

igorostrowskiq force-pushed the igorostrowskiq_unify_cit_structure branch from 9b6691f to 7fbf983 Compare December 16, 2025 17:47

igorostrowskiq requested a review from Copilot December 16, 2025 17:51

Copilot AI reviewed Dec 16, 2025

View reviewed changes

PiotrKorkus reviewed Dec 16, 2025

View reviewed changes

PiotrKorkus reviewed Dec 18, 2025

View reviewed changes

.github/workflows/component_integration_tests.yml Outdated Show resolved Hide resolved

.github/workflows/component_integration_tests.yml Outdated Show resolved Hide resolved

pyproject.toml Outdated Show resolved Hide resolved

pyproject.toml Show resolved Hide resolved

PiotrKorkus reviewed Dec 18, 2025

View reviewed changes

.github/workflows/component_integration_tests.yml Outdated Show resolved Hide resolved

PiotrKorkus previously approved these changes Dec 19, 2025

View reviewed changes

igorostrowskiq force-pushed the igorostrowskiq_unify_cit_structure branch from 01ef5d7 to a9130f3 Compare December 19, 2025 13:48

arkjedrz suggested changes Jan 9, 2026

View reviewed changes

PiotrKorkus dismissed their stale review via 7b54870 January 13, 2026 12:28

PiotrKorkus force-pushed the igorostrowskiq_unify_cit_structure branch from a9130f3 to 7b54870 Compare January 13, 2026 12:28

PiotrKorkus mentioned this pull request Jan 13, 2026

Ruff formatting for Python files #213

Merged

PiotrKorkus requested a review from arkjedrz January 13, 2026 12:35

arkjedrz suggested changes Jan 19, 2026

View reviewed changes

arkjedrz force-pushed the igorostrowskiq_unify_cit_structure branch from 7b54870 to f357f46 Compare January 19, 2026 14:18

arkjedrz approved these changes Jan 19, 2026

View reviewed changes

testing: Unify component integration tests structure

eb1d61e

arkjedrz force-pushed the igorostrowskiq_unify_cit_structure branch from f357f46 to eb1d61e Compare January 19, 2026 14:21

PiotrKorkus approved these changes Jan 19, 2026

View reviewed changes

PiotrKorkus merged commit 6411e65 into eclipse-score:main Jan 19, 2026
14 checks passed

PiotrKorkus deleted the igorostrowskiq_unify_cit_structure branch January 19, 2026 15:48

tizava pushed a commit to etas-contrib/score_persistency that referenced this pull request Jan 23, 2026

Merge pull request eclipse-score#199 from qorix-group/igorostrowskiq_…

b562d7a

…unify_cit_structure testing: Unify component integration tests structure

Conversation

igorostrowskiq commented Dec 16, 2025

Uh oh!

github-actions bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Dec 16, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PiotrKorkus left a comment

Choose a reason for hiding this comment

Uh oh!

igorostrowskiq commented Dec 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PiotrKorkus Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 16, 2025 •

edited

Loading

PiotrKorkus Jan 19, 2026 •

edited

Loading