Skip to content

hmon: add heartbeat monitor #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
arkjedrz wants to merge 1 commit into
base: main
Choose a base branch
from
+1,707 −145
Draft

hmon: add heartbeat monitor #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/lint_clippy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,14 @@ jobs:
override: true
components: clippy

- name: check clippy errors
- name: check clippy errors (with "--features stub_supervisor_api_client")
uses: actions-rs/cargo@v1
with:
command: clippy
args: --all-features --all-targets --workspace -- -D warnings
args: --features stub_supervisor_api_client --all-targets -- -D warnings
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared to the previous workflow, these clippy invocations no longer pass --workspace, which can reduce lint coverage to only the default package(s) and miss issues in other workspace crates (e.g., examples). If feature conflicts were the reason for dropping --workspace, consider (1) keeping a separate cargo clippy --workspace step without feature overrides, and (2) running feature-specific clippy scoped to -p health_monitoring_lib.

Copilot uses AI. Check for mistakes.

- name: check clippy errors (with "--features score_supervisor_api_client")
uses: actions-rs/cargo@v1
with:
command: clippy
args: --features score_supervisor_api_client --no-default-features --all-targets -- -D warnings
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared to the previous workflow, these clippy invocations no longer pass --workspace, which can reduce lint coverage to only the default package(s) and miss issues in other workspace crates (e.g., examples). If feature conflicts were the reason for dropping --workspace, consider (1) keeping a separate cargo clippy --workspace step without feature overrides, and (2) running feature-specific clippy scoped to -p health_monitoring_lib.

Copilot uses AI. Check for mistakes.
3 changes: 3 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
"rust-analyzer.cargo.cfgs": [
"!miri"
],
"rust-analyzer.cargo.features": [
"stub_supervisor_api_client"
],
"rust-analyzer.check.command": "clippy",
"rust-analyzer.rustfmt.overrideCommand": [
"${workspaceFolder}/.vscode/rustfmt.sh"
Expand Down
Loading
Loading