-
Notifications
You must be signed in to change notification settings - Fork 14
Implementing report running state in lifecycle manager #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implementing report running state in lifecycle manager #55
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
|
Changes look good to me👍 lifecycle/examples/cpp_lifecycle_app/main.cpp Line 134 in c7d58e9
We can then reuse this example app for an automated integration test. |
a70ccde to
5b0b39e
Compare
| signal(SIGINT, signalHandler); | ||
| signal(SIGTERM, signalHandler); | ||
| signal(SIGINT, signalHandler); | ||
| signal(SIGTERM, signalHandler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the signal handling is now already done within lifecyclemanager.cpp
So I believe the custom signal handling here and the flag exitRequested could be removed and instead we use the stopToken in the Run() method
Implementing report running state in lifecycle manager as per discussion with @NicolasFussberger on slack.