Update workflow to include unit tests by WilliamRoebuck · Pull Request #45 · eclipse-score/lifecycle

WilliamRoebuck · 2026-01-21T15:04:01Z

Moved unit tests from separate directory to src

github-actions · 2026-01-21T15:05:07Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
2026/01/26 14:57:28 Downloading https://releases.bazel.build/8.4.2/release/bazel-8.4.2-linux-x86_64...
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: 08860c5f-df41-4982-b95b-b335f7bc886d
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-eQOopREOYCL5vtTb6c1cwZrql4GVrJ1FqgxarQRe1xs="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 2 packages loaded
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)

Analyzing: target //:license-check (35 packages loaded, 10 targets configured)

Analyzing: target //:license-check (89 packages loaded, 10 targets configured)

Analyzing: target //:license-check (137 packages loaded, 2424 targets configured)

Analyzing: target //:license-check (153 packages loaded, 4964 targets configured)

Analyzing: target //:license-check (153 packages loaded, 4964 targets configured)

Analyzing: target //:license-check (154 packages loaded, 4964 targets configured)

Analyzing: target //:license-check (158 packages loaded, 9065 targets configured)

Analyzing: target //:license-check (161 packages loaded, 13571 targets configured)

Analyzing: target //:license-check (161 packages loaded, 13571 targets configured)

INFO: Analyzed target //:license-check (162 packages loaded, 13697 targets configured).
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 26.324s, Critical Path: 0.34s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-01-21T15:06:27Z

The created documentation from the pull request is available at: docu-html

pawelrutkaq · 2026-01-22T13:11:27Z

Why we need to split this in a job ? I am not sure if this will not make bazel cold again and increase times.

WilliamRoebuck · 2026-01-22T16:04:05Z

Why we need to split this in a job ? I am not sure if this will not make bazel cold again and increase times.

Good point, I've combined the tests now. I think it would be nice to have separate jobs in future to make it clearer what failed but it would require a more complex workflow to keep the cache between tests

pawelrutkaq · 2026-01-26T10:30:28Z

.github/workflows/tests.yml

      pull-requests: read
    with:
-      bazel-target: 'test //src/...'
+      bazel-target: 'test //src/... //tests/ut/...'


This directory is not for UT afaik, but for cit tests. So we shall move UT from there is put there and not run it here.

@PiotrKorkus ?

correct, UTs are located among the implementation. Please take a look e.g.: https://github.com/eclipse-score/baselibs/blob/main/score/mw/log/BUILD

I don't think we should follow the baselibs layout for this - according to the s-core module template, both unit and integration tests should be in the tests/ directory:
https://github.com/eclipse-score/module_template/blob/092be5c428a9d1c96ec7a0e02522107a591794bc/README.md?plain=1#L21

Then the template shall be updated - I will handle that.

All other features are storing UTs side to side with sources. That's also a good practice for rust where unit tests are recommended to be kept in the same file as implementation.

Ye also temaplate src folder is [probably goign to change into score

eclipse-score/module_template#42

pawelrutkaq

Besides rebase look good now

pawelrutkaq · 2026-01-26T14:11:34Z

src/launch_manager_daemon/health_monitor_lib/src/score/lcm/saf/daemon/PhmDaemon.cpp

 PhmDaemon::PhmDaemon(score::lcm::saf::timers::OsClockInterface& f_osClock, logging::PhmLogger& f_logger_r,
                     std::unique_ptr<watchdog::IWatchdogIf> f_watchdog, std::unique_ptr<score::lcm::IProcessStateReceiver> f_process_state_receiver) :
-    osClock{f_osClock}, cycleTimer{&osClock}, logger_r{f_logger_r}, swClusterHandlers{}, watchdog(std::move(f_watchdog)), processStateReader{std::move(f_process_state_receiver)}
+    osClock{f_osClock}, cycleTimer{&osClock}, logger_r{f_logger_r}, swClusterHandlers{}, processStateReader{std::move(f_process_state_receiver)}, watchdog(std::move(f_watchdog))


I think you did not rebased on main, this change is already in or ? https://github.com/eclipse-score/lifecycle/blob/main/src/launch_manager_daemon/health_monitor_lib/src/score/lcm/saf/daemon/PhmDaemon.cpp#L40

WilliamRoebuck temporarily deployed to workflow-approval January 21, 2026 15:04 — with GitHub Actions Inactive

WilliamRoebuck temporarily deployed to workflow-approval January 22, 2026 15:54 — with GitHub Actions Inactive

WilliamRoebuck temporarily deployed to workflow-approval January 22, 2026 16:05 — with GitHub Actions Inactive

pawelrutkaq reviewed Jan 26, 2026

View reviewed changes

MaciejKaszynski mentioned this pull request Jan 26, 2026

Deadline monitoring CPP API #48

Merged

WilliamRoebuck temporarily deployed to workflow-approval January 26, 2026 12:53 — with GitHub Actions Inactive

WilliamRoebuck temporarily deployed to workflow-approval January 26, 2026 13:35 — with GitHub Actions Inactive

pawelrutkaq reviewed Jan 26, 2026

View reviewed changes

WilliamRoebuck added 6 commits January 26, 2026 14:53

Add unit test job

c1aa262

Renamed jobs

c19a2a1

Simplified test action to prevent rebuilding for each test type

6c50e66

Fix formatting

e09332b

Moved UT to src directory

f2caaae

Removed tests from copyright check

3d69487

WilliamRoebuck force-pushed the feature/add-test-actions branch from 88525cc to 3d69487 Compare January 26, 2026 14:56

WilliamRoebuck temporarily deployed to workflow-approval January 26, 2026 14:57 — with GitHub Actions Inactive

pawelrutkaq approved these changes Jan 27, 2026

View reviewed changes

pawelrutkaq merged commit 046ea28 into eclipse-score:main Jan 27, 2026
11 checks passed

Conversation

WilliamRoebuck commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

pawelrutkaq commented Jan 22, 2026

Uh oh!

WilliamRoebuck commented Jan 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WilliamRoebuck commented Jan 21, 2026 •

edited

Loading

github-actions bot commented Jan 21, 2026 •

edited

Loading