Fix potential race condition in class JobRunner#15
Open
BjoernAtBosch wants to merge 1 commit intoeclipse-score:mainfrom
Open
Fix potential race condition in class JobRunner#15BjoernAtBosch wants to merge 1 commit intoeclipse-score:mainfrom
BjoernAtBosch wants to merge 1 commit intoeclipse-score:mainfrom
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
lavrovvalera
approved these changes
Apr 20, 2026
Contributor
Author
|
@FScholPer, @umaucher: Can someone of you "give this a go" to enable merging? Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status check in
JobRunner::Startcould lead to a potential race condition, ifStartis called by multiple threads within a short period, because the status is checked without any lock guard before changing it.This small fix prevent the issue.
Alternatively this could be fixed using an atomic variable, but I didn't want to spend the effort now.