Fix implementation of gd_req__saf_linkage_status_check#528
Open
PandaeDo wants to merge 1 commit intoeclipse-score:mainfrom
Open
Fix implementation of gd_req__saf_linkage_status_check#528PandaeDo wants to merge 1 commit intoeclipse-score:mainfrom
PandaeDo wants to merge 1 commit intoeclipse-score:mainfrom
Conversation
PandaeDo
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
| mitigated_by: safety != QM | ||
| mitigated_by: | ||
| and: | ||
| - safety != QM |
Contributor
There was a problem hiding this comment.
Is mittigated_by here the only thing that can have linked requirements?
According to the text it says that all linkages must fulfill this.
Cant check the code atm on phone. So if this is correct then looks good.
a-zw
suggested changes
May 7, 2026
| # - <Feature | Component | AoU> Requirements with the same ASIL or | ||
| # - <Feature | Component | AoU> Requirements with a higher ASIL | ||
| # as the corresponding ASIL of the Feature or Component that is analyzed. | ||
| # req-Id: tool_req__docs_saf_attrs_mitigated_by |
Contributor
There was a problem hiding this comment.
I believe tool_req__docs_saf_attrs_mitigated_by needs an update for this. It should satisfy gd_req__saf_linkage_status_check, for example.
| - safety == ASIL_B | ||
| - status == valid | ||
| check: | ||
| mitigated_by: safety != QM |
Contributor
There was a problem hiding this comment.
Some tests are failing. In this case the tests need to be adapted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
The status check is missing in the actual implementation of gd_req__saf_linkage_status_check. Now it's added.
🚨 Impact Analysis
✅ Checklist