Remove LLVM and Rust features #84
Draft
+41
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They increase the image by 2.7GB and might not be needed since bazel or the extensions are able to download the binaries as well.
Contributor
Author
|
Testing shows that still headers from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the image size by 2GB. Combined feature size was 2.7GB.
The assumption is that toolchains are downloaded by bazel and IDE extensions are able to download binaries if needed.
This removes the option to build Rust with cargo. E.g. persistency seems still to use
Cargo.tomlfiles. It encourages to use bazel instead, but who knows if that is really followed.