mw/com: Remove SOME/IP configuration structs#406
Open
sahithi-nukala wants to merge 4 commits into
Open
Conversation
Remove the placeholder SOME/IP configuration structs that were never connected to a real transport implementation: - SomeIpServiceInstanceDeployment - SomeIpServiceInstanceId - SomeIpEventInstanceDeployment - SomeIpFieldInstanceDeployment
- Remove SOME/IP from BindingInformation variants in ServiceInstanceDeployment and ServiceInstanceId - Remove SOME/IP binding type and error codes from config_parser, configuration_error, and mw_com_config_schema.json - Fix operator== and operator< for blank binding in ServiceInstanceId - Remove SOME/IP targets from BUILD - Update tests and test helpers accordingly
- Remove SomeIpServiceInstanceDeployment visitor lambdas from all binding factory implementations - Remove CreateSomeIpBindingInstanceIdentifier from test helper - Remove SOME/IP typed test cases from all plumbing factory tests - Remove SOME/IP visitor from GetServiceInstanceId in instance_identifier
sahithi-nukala
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
crimson11
requested changes
May 13, 2026
| instances. | ||
| What is **not** visible here: Whether `"abc/abc/TirePressurePort"` is a provided or required service instance. Both | ||
| could be possible, since we do support 1 to n mappings in both cases. | ||
| Here we have a mapping of `"abc/abc/TirePressurePort"` to two different concrete technical instances: The first one is a |
Contributor
There was a problem hiding this comment.
Here (and only here) I would keep the SOME/IP part. Why, because it shows, which general flexibility we do foresee within our config. So keep the old text - maybe with a slight adaption:
SOME/IP based instance (so ...
hypothetic SOME/IP based instance (so ...
- Remove SOME/IP from supported bindings lists in README files - Update example configurations to use SHM-only binding - Remove SomeIpServiceInstanceDeployment from structural_view.puml
sahithi-nukala
force-pushed
the
sah_remove_someip_config_structs
branch
from
374e0b3 to
4a16710
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.