Update skeleton slot based on notifier enable tag#382
Draft
KrishaDeshkool wants to merge 11 commits intoeclipse-score:mainfrom
Draft
Update skeleton slot based on notifier enable tag#382KrishaDeshkool wants to merge 11 commits intoeclipse-score:mainfrom
KrishaDeshkool wants to merge 11 commits intoeclipse-score:mainfrom
Conversation
KrishaDeshkool
force-pushed
the
update_skeleton_slot_based_on_notifier_enable_tag
branch
from
e3c67ba to
3d98561
Compare
The new order allows us to set the bindings to nullptrs by default for test only constructors. This will be useful for fields which will require optionally inserting get / set bindings. We change all constructors so that they're all consistent.
- Use a single test constructor which creates the get / set methods according to the provided bindings. This allows us to remove the test-only constructor overloads for each template arg combination. - Always store the get / set method dispatches as unique_ptrs even if they're not enabled (when disabled, they'll simply be nullptrs). This allows us to have a single private constructor which always accepts unique_ptrs (which may be valid or nullptrs).
Replaces the EnableGet/EnableSet/EnableNotifier bool template parameters on ProxyField and SkeletonField with a variadic pack of tags (WithGetter, WithSetter) declared in field_tags.h. Presence of a tag enables the matching API. The notifier surface stays unconditional on both sides, since a field without a notifier cannot propagate value changes. Also updates friend/forward declarations in ProxyEvent, ProxyMethod, SkeletonEvent and SkeletonMethod, the Trait::Field aliases plus the traits example doc, and the skeleton_field_test.cpp call sites.
when both getter and notification mechanism is turned off there is no way for the consumer to observe the field values. making this configuration a compile time failure.
KrishaDeshkool
force-pushed
the
update_skeleton_slot_based_on_notifier_enable_tag
branch
from
3d98561 to
c88e5d6
Compare
KrishaDeshkool
force-pushed
the
update_skeleton_slot_based_on_notifier_enable_tag
branch
from
c88e5d6 to
fe2db0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a part of bigger PR that handles the changes from the boolean based setter/getter/notifier enabling mechanism to tag based enabling system,