Conversation
hoe-jo
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11 and
limdor
as code owners
hoe-jo
force-pushed
the
joho_add_dependable_element_message_passing
branch
from
2d6c69a to
999ebf2
Compare
| @@ -0,0 +1,12 @@ | |||
| # ******************************************************************************* | |||
There was a problem hiding this comment.
this should be under the folder requirements
| load("@trlc//:trlc.bzl", "trlc_requirements", "trlc_requirements_test") | ||
|
|
||
| trlc_requirements( | ||
| name = "feature_requirements_trlc", |
There was a problem hiding this comment.
Why is this not in the feature requirements folder?
There was a problem hiding this comment.
Why do we call it _trlc at the end?
I also do not call my cc_library foo_cpp
| ":component_requirements_trlc", | ||
| ], | ||
| visibility = ["//visibility:public"], | ||
| ) |
There was a problem hiding this comment.
We should have here a test_suite that executes all requirements based tests.
| trlc_requirements( | ||
| name = "failure_modes", | ||
| srcs = [ | ||
| "failure_modes.trlc", | ||
| ], | ||
| spec = [ | ||
| "@score_tooling//bazel/rules/rules_score/trlc/config:score_requirements_model", | ||
| ], | ||
| visibility = ["//visibility:public"], | ||
| ) |
There was a problem hiding this comment.
Can we please avoid this copy n paste and hide this directly in the FMEA bazel rule, that you define there directly the trlc files?
| trlc_requirements( | ||
| name = "control_measures", | ||
| srcs = [ | ||
| "control_measures.trlc", | ||
| ], | ||
| spec = [ | ||
| "@score_tooling//bazel/rules/rules_score/trlc/config:score_requirements_model", | ||
| ], | ||
| visibility = ["//visibility:public"], | ||
| deps = [ | ||
| ":failure_modes", | ||
| ], | ||
| ) |
There was a problem hiding this comment.
Should we not place this in the "component requirements"?
There was a problem hiding this comment.
Depends if the control measure is a component requirement or an AoU
| @@ -0,0 +1,49 @@ | |||
| # ******************************************************************************* | |||
There was a problem hiding this comment.
let's please call this folder software_unit_design
| architectural_design( | ||
| name = "message_passing_design", | ||
| static = ["client-server.md"], | ||
| visibility = ["//visibility:public"], | ||
| ) |
There was a problem hiding this comment.
We should move this to software_architectural_design
| ], | ||
| tags = ["FFI"], | ||
| visibility = [ | ||
| "//score/message_passing/dependability:__subpackages__", |
There was a problem hiding this comment.
I think these visibilities are wrong, and should be removed and the units should be moved to the code.
| @@ -1,3 +1,16 @@ | |||
| # ******************************************************************************* | |||
There was a problem hiding this comment.
This file holds already a copyright...
| commit = "4c83c578069768c6133e4268b63929646754f6a6", | ||
| commit = "87de61455a9f699041dd0ca5a2c9cf0fcd771476", | ||
| remote = "https://github.com/eclipse-score/tooling.git", | ||
| ) |
There was a problem hiding this comment.
you will need to adapt the example folder as well, for this to work when you remove the dev dependency.
hoe-jo
force-pushed
the
joho_add_dependable_element_message_passing
branch
from
999ebf2 to
d8b95f6
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| "Ensure @score_tooling//tools/sphinx:plantuml is in sphinx_build data." | ||
| ) | ||
| else: | ||
| plantuml = str(_plantuml_path) |
| ) | ||
| else: | ||
| plantuml = str(_plantuml_path) | ||
| plantuml_output_format = "svg_obj" |
| import bazel_sphinx_needs | ||
|
|
||
| from pathlib import Path | ||
| import os |
hoe-jo
force-pushed
the
joho_add_dependable_element_message_passing
branch
4 times, most recently
from
19041d7 to
ef88b39
Compare
- add jvm for plantuml - enhance gitignore
hoe-jo
force-pushed
the
joho_add_dependable_element_message_passing
branch
from
ef88b39 to
76f8202
Compare
2 participants
No description provided.