Rust::com Derive macro for CommData #156
Conversation
bharatGoswami8
requested review from
LittleHuba,
castler and
hoe-jo
as code owners
| /// If no custom ID is provided, the struct or enum name is used as the ID. | ||
| /// Example usage: | ||
| /// ``` | ||
| /// pub trait CommData { |
There was a problem hiding this comment.
add to doc of ComData trait that user shall not implement manually but use this macros.
There was a problem hiding this comment.
Updated Documentation.
There was a problem hiding this comment.
I meant to place where pub trait ComData is defined.
There was a problem hiding this comment.
Added documentation on - com-api/com-api-concept/com_api_concept.rs
bharatGoswami8
force-pushed
the
rust_com_api_derive_macro_commData
branch
from
719a3c7 to
7524795
Compare
| }; | ||
|
|
||
| if !nv.path.is_ident("id") { | ||
| continue; |
There was a problem hiding this comment.
if it snot id, then it shall be error or ?
There was a problem hiding this comment.
Agreed, we should return error if it is not id.
| /// If no custom ID is provided, the struct or enum name is used as the ID. | ||
| /// Example usage: | ||
| /// ``` | ||
| /// pub trait CommData { |
There was a problem hiding this comment.
I meant to place where pub trait ComData is defined.
| }; | ||
|
|
||
| let Ok(Meta::NameValue(nv)) = list.parse_args::<Meta>() else { | ||
| continue; |
There was a problem hiding this comment.
if its anything else then also error ?
There was a problem hiding this comment.
maybe add test cases for it
There was a problem hiding this comment.
Agreed, we should return error.
* Implemented derive macro for CommData trait impl
bharatGoswami8
force-pushed
the
rust_com_api_derive_macro_commData
branch
from
7524795 to
14a7f51
Compare
2 participants
#155