Provide a composite action for setting up qnx sdp usage#2
Open
MTomBosch wants to merge 14 commits intoeclipse-score:mainfrom
Open
Provide a composite action for setting up qnx sdp usage#2MTomBosch wants to merge 14 commits intoeclipse-score:mainfrom
MTomBosch wants to merge 14 commits intoeclipse-score:mainfrom
Conversation
- Log if qnx license file will be overwritten. - Only run with sudo if really required - Add qnx.com credential helper check
Use hyphens in input params instead of underscores.
MTomBosch
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
PiotrKorkus,
dcalavrezo-qorix,
lurtz and
pawelrutkaq
as code owners
Member
|
We should convert this to JS/TS with a proper post step. |
| qnx-credential-helper: | ||
| description: Workspace root relative or absolute path to the QNX credential helper script that allows Bazel to access qnx.com with the provided credentials (qnx-user and qnx-password). If path is given but file does not exist an error will be raised. If an empty string is given no check will be performed. If file exists it is set to be executable. Finally a GITHUB_ENV var QNX_CREDENTIAL_HELPER is set with the absolute path to the credential helper script. | ||
| required: false | ||
| default: .github/tools/qnx_credential_helper.py |
Member
There was a problem hiding this comment.
We need to get rid of this local file. Maybe we can simply move it to qnx toolchain? So the toolchain itself behaves the same locally and on CI. Although currently the toolchain states, that SDP is out of scope and the user is responsible. As there are hundreds of ways to get the SDP. By that logic CI is responsible, and it should not be a local script.
No good idea at the moment.
I guess we have:
- CI: currently uses qnx.com download until we can figure out local storage. Which we hopefully will in the next days to come.
- S-CORE developer: will still download individually from qnx.com
- End-Users / internal development based on S-CORE: will have their own internal SDP storage, as they cannot use the one from S-CORE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new composite GitHub Action,
setup-qnx-sdp, to simplify and standardize the setup of the QNX Software Development Platform (SDP) in CI workflows. The action manages QNX license files, configures license server access, checks availability of qnx.com portal related credential helper, and ensures secure access to qnx.com.This was tested by putting it into the qnx-build-yml resuable workflow (eclipse-score/cicd-workflows#107) and then running it on a company internal repository.