added QNX SPD CLI support#57
Open
srinivasugithub wants to merge 9 commits into
Open
Conversation
srinivasugithub
requested review from
AlexanderLanin,
antonkri,
dcalavrezo-qorix and
nradakovic
as code owners
nradakovic
requested changes
May 27, 2026
| @@ -0,0 +1,26 @@ | |||
| # ******************************************************************************* | |||
Member
There was a problem hiding this comment.
Why did you create module here? As far as I can see, we don't need this.
| ) | ||
|
|
||
| # Package the SDP as a tarball for distribution (optional) | ||
| genrule( |
Member
There was a problem hiding this comment.
We don't need genrule to package the output of CLI QNX (SDP). Bazel support already all sorts of packaging rules like pkg_tar or pkg_zip.
| ) | ||
|
|
||
| # Create a filegroup that references the output directory | ||
| filegroup( |
|
|
||
| # Download the QNX installer | ||
| http_file( | ||
| name = "qnx_installer", |
Member
There was a problem hiding this comment.
I really believe it would be good to get this installer as binary from somewhere rather than installing it like this. I will check with QNX if this is possible.
|
|
||
| """Rule to create a QNX SDP distribution from a patchset file.""" | ||
|
|
||
| def _qnx_sdp_distribution_impl(ctx): |
Member
There was a problem hiding this comment.
why we need to run the command over the script? Why not directly via ctx.actuins.run?
| # "gcc_version": "12.2.0", | ||
| # }, | ||
| "aarch64-qnx-sdp_8.0.0": { | ||
| "build_file": "@score_bazel_cpp_toolchains//packages/qnx/aarch64/sdp/8.0.0:sdp.BUILD", |
Member
There was a problem hiding this comment.
Please do not remove old references, just add the new one if you need them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added QNX SPD CLI support