Skip to content

Only set dialog.setOpenOnRun(false) according to preference #486#4124

Open
fedejeanne wants to merge 1 commit into
eclipse-platform:masterfrom
fedejeanne:progress_monitor_run_in_background
Open

Only set dialog.setOpenOnRun(false) according to preference #486#4124
fedejeanne wants to merge 1 commit into
eclipse-platform:masterfrom
fedejeanne:progress_monitor_run_in_background

Conversation

@fedejeanne

@fedejeanne fedejeanne commented Jun 19, 2026

Copy link
Copy Markdown
Member

Fixes #4086

@fedejeanne fedejeanne mentioned this pull request Jun 19, 2026
Open
@iloveeclipse iloveeclipse requested a review from Copilot June 19, 2026 13:51
Copilot AI reviewed Jun 19, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how the workbench progress service decides whether to open a modal progress dialog when running “backward compatible” operations (ProgressManager#run branch for !fork || !cancelable). It aims to restore expected progress reporting behavior (Issue #4086) by only disabling automatic dialog opening (setOpenOnRun(false)) when the “Always run in background” preference indicates dialogs should not be shown.

Changes:

  • Moves dialog.setOpenOnRun(false) so it is applied only when shouldRunInBackground() is true.
  • Keeps the delayed “open progress dialog” scheduling path when dialogs are allowed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ...les/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/progress/ProgressManager.java
Comment on lines 977 to 981
if (!shouldRunInBackground()) {
scheduleProgressMonitorJob(dialog);
} else {
dialog.setOpenOnRun(false);
}
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Test Results

   855 files  ±0     855 suites  ±0   55m 30s ⏱️ + 4m 5s
 8 075 tests ±0   7 830 ✅  - 2  243 💤 ±0  2 ❌ +2 
20 127 runs  ±0  19 471 ✅  - 2  654 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 5639b51. ± Comparison against base commit 552c9e4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PlatformUI.getWorkbench().getProgressService().run(true, false, runnable) fails to report progress

2 participants

@fedejeanne