Unify JFace popup dialog menu icon with workbench view menu#4118
Open
vogella wants to merge 1 commit into
Open
Unify JFace popup dialog menu icon with workbench view menu#4118vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
Contributor
The PopupDialog menu button used the old blue gradient chevron while workbench view menus already use the three vertical dots glyph. Replace the JFace popup_menu artwork (enabled and disabled variants) with the view_menu three-dots design so both controls match. Fixes eclipse-platform#4089
vogella
force-pushed
the
jface-popup-menu-icon-unify
branch
from
c29cceb to
0963061
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JFace
PopupDialogrendered its top-right menu button with the old blue gradient chevron, while workbench view menus already use the modern three vertical dots glyph. This replaces the JFacepopup_menuartwork (both the enabled and disabled variants) with copies of the workbenchview_menuthree-dots design, so the CTRL+3 Find Actions dialog and any other PopupDialog with a dialog menu now match nearby view menus. The disabled icon is a greyed version of the same glyph using the existing disabled palette. The registration keypopup_menu_imageis unchanged, so there is no API impact, and the third JFace-local copy follows the existing pattern since JFace cannot depend on the workbench bundle.Fixes #4089