Skip to content

[GTK] Remove always false local variable #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonahgraham merged 1 commit into from
Dec 9, 2025
Merged

[GTK] Remove always false local variable #2856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Shell.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,17 +580,7 @@ void bringToTop (boolean force) {
if (focusHandle != 0 && !GTK.gtk_widget_has_focus (focusHandle)) return;
}
}
/*
* Bug in GTK. When a shell that is not managed by the window
* manage is given focus, GTK gets stuck in "focus follows pointer"
* mode when the pointer is within the shell and its parent when
* the shell is hidden or disposed. The fix is to use XSetInputFocus()
* to assign focus when ever the active shell has not managed by
* the window manager.
*
* NOTE: This bug is fixed in GTK+ 2.6.8 and above.
*/
boolean xFocus = false;

if (activeShell != null) {
display.activeShell = null;
display.activePending = true;
Expand All @@ -607,7 +597,7 @@ void bringToTop (boolean force) {
} else {
gdkResource = gtk_widget_get_window (shellHandle);
}
if ((xFocus || (style & SWT.ON_TOP) != 0)) {
if ((style & SWT.ON_TOP) != 0) {
if (OS.isX11()) {
long gdkDisplay;
if (GTK.GTK4) {
Expand Down
Loading