Skip to content

Exclude TODO tests by default, include them with runtodotests label #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonahgraham merged 1 commit into from
Nov 13, 2025
Merged

Exclude TODO tests by default, include them with runtodotests label #2765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ on:
type: boolean
required: false
default: false
runtodotests:
description: "Run TODO tagged tests too (one of true, false)"
type: boolean
required: false
default: false

jobs:
build:
Expand Down Expand Up @@ -66,6 +71,7 @@ jobs:
--fail-at-end
-DskipNativeTests=false
-DfailIfNoTests=false
${{ (inputs.runtodotests == false && contains(inputs.native, 'linux')) && '-DexcludedGroups=gtk3-todo' || '' }}
clean install
- name: Performance tests
if: ${{ inputs.performance }}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ jobs:
java: ${{ matrix.java }}
native: gtk.linux.x86_64
performance: ${{ contains(github.event.pull_request.labels.*.name, 'performance') }}
runtodotests: ${{ contains(github.event.pull_request.labels.*.name, 'runtodotests') }}

build-windows:
name: Build (Windows)
Expand All @@ -59,6 +60,7 @@ jobs:
java: ${{ matrix.java }}
native: win32.win32.x86_64
performance: ${{ contains(github.event.pull_request.labels.*.name, 'performance') }}
runtodotests: ${{ contains(github.event.pull_request.labels.*.name, 'runtodotests') }}

build-macos:
name: Build (macOS)
Expand All @@ -79,3 +81,4 @@ jobs:
java: ${{ matrix.java }}
native: ${{ matrix.native }}
performance: ${{ contains(github.event.pull_request.labels.*.name, 'performance') }}
runtodotests: ${{ contains(github.event.pull_request.labels.*.name, 'runtodotests') }}
Loading