Skip to content

Fix and simplify pde.ds.annotations.tests#2085

Merged
HannesWell merged 1 commit intoeclipse-pde:masterfrom
HannesWell:fix-pde.ds.annotation.tests
Feb 9, 2026
Merged

Fix and simplify pde.ds.annotations.tests#2085
HannesWell merged 1 commit intoeclipse-pde:masterfrom
HannesWell:fix-pde.ds.annotation.tests

Conversation

@HannesWell
Copy link
Copy Markdown
Member

@HannesWell HannesWell commented Nov 1, 2025

Convert assumptions to assertions since all of them should actually be assertions.
Furthermore this replaces leftover JUnit-4 assumptions.

This is currently a draft as not everything is working yet locally.

Follow-up on

@eclipse-pde-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 7092b5d533d531381c8d30ae873a4c3fdd120548 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Sat, 1 Nov 2025 15:29:04 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF b/ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF
index 51e4220f81..7da71696df 100644
--- a/ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF
+++ b/ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.pde.ds.annotations;singleton:=true
-Bundle-Version: 1.4.200.qualifier
+Bundle-Version: 1.4.300.qualifier
 Bundle-Activator: org.eclipse.pde.ds.internal.annotations.Activator
 Bundle-Vendor: %Bundle-Vendor
 Require-Bundle: org.eclipse.ui;bundle-version="[3.105.0,4.0.0)",
-- 
2.51.2

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 1, 2025

Test Results

   798 files  ± 0     798 suites  ±0   58m 56s ⏱️ - 2m 14s
 3 787 tests +55   3 733 ✅ +138   54 💤  -  82  0 ❌  - 1 
11 127 runs  ± 0  10 964 ✅ +247  163 💤  - 246  0 ❌  - 1 

Results for commit cf76c4d. ± Comparison against base commit d2bff11.

This pull request removes 27 and adds 82 tests. Note that renamed tests count towards both.
org.eclipse.pde.ds.internal.annotations.tests.FullComponentTestV1_2 ‑ componentActivateMethod
org.eclipse.pde.ds.internal.annotations.tests.FullComponentTestV1_2 ‑ componentConfigurationPid
org.eclipse.pde.ds.internal.annotations.tests.FullComponentTestV1_2 ‑ componentConfigurationPolicy
org.eclipse.pde.ds.internal.annotations.tests.FullComponentTestV1_2 ‑ componentDeactivateMethod
org.eclipse.pde.ds.internal.annotations.tests.FullComponentTestV1_2 ‑ componentEnabled
org.eclipse.pde.ds.internal.annotations.tests.FullComponentTestV1_2 ‑ componentFactory
org.eclipse.pde.ds.internal.annotations.tests.FullComponentTestV1_2 ‑ componentImmediate
org.eclipse.pde.ds.internal.annotations.tests.FullComponentTestV1_2 ‑ componentImplementationClass
org.eclipse.pde.ds.internal.annotations.tests.FullComponentTestV1_2 ‑ componentModifiedMethod
org.eclipse.pde.ds.internal.annotations.tests.FullComponentTestV1_2 ‑ componentName
…
AllDSAnnotationsTests DefaultComponentTest ‑ componentImplementationClass
AllDSAnnotationsTests DefaultComponentTest ‑ componentName
AllDSAnnotationsTests DefaultComponentTest ‑ componentNamespace
AllDSAnnotationsTests DefaultComponentTest ‑ componentReference
AllDSAnnotationsTests DefaultComponentTest ‑ componentServiceProviderInterface
AllDSAnnotationsTests ErrorProjectTest ‑ delayedWithNoServicesError
AllDSAnnotationsTests ErrorProjectTest ‑ duplicateConfigurationPidError
AllDSAnnotationsTests ErrorProjectTest ‑ factoryImmediateError
AllDSAnnotationsTests ErrorProjectTest ‑ factoryOrImmediateServiceFactoryError
AllDSAnnotationsTests ErrorProjectTest ‑ missingImplicitDynamicReferenceUnbindMethodError
…

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the fix-pde.ds.annotation.tests branch from f2ea1c6 to 45beb1e Compare January 17, 2026 13:51
@HannesWell HannesWell marked this pull request as ready for review January 17, 2026 13:51
@HannesWell HannesWell changed the title Fix and run pde.ds.annotation.tests and replace leftover JUnit-4 Assume Fix and simplify pde.ds.annotation.tests Jan 17, 2026
@HannesWell HannesWell force-pushed the fix-pde.ds.annotation.tests branch 8 times, most recently from ef1f9d6 to 4944a37 Compare January 19, 2026 07:46
@HannesWell HannesWell force-pushed the fix-pde.ds.annotation.tests branch 4 times, most recently from a58f8d8 to 742ce88 Compare February 5, 2026 21:06
@HannesWell HannesWell changed the title Fix and simplify pde.ds.annotation.tests Fix and simplify pde.ds.annotations.tests Feb 5, 2026
@HannesWell HannesWell force-pushed the fix-pde.ds.annotation.tests branch 2 times, most recently from 14122a1 to 5ce2393 Compare February 5, 2026 22:28
Also convert assumptions to assertions since all of them should actually
be assertions.
@HannesWell HannesWell force-pushed the fix-pde.ds.annotation.tests branch from 5ce2393 to cf76c4d Compare February 5, 2026 23:10
@HannesWell
Copy link
Copy Markdown
Member Author

Finally all tests pass.
Thanks to Ed and Christoph for your help and hints regarding MacOS.

@HannesWell HannesWell merged commit 2cb040e into eclipse-pde:master Feb 9, 2026
19 checks passed
@HannesWell HannesWell deleted the fix-pde.ds.annotation.tests branch February 9, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants