Fix formatting of DSpace item repository ids

[markpatton]

Handles the case of item URLs (produced by REST API deposit) and handle URLs (produced by old SWORD deposit)

[Copilot]

Pull Request Overview

This PR refactors how repository IDs are formatted by extracting the substring after known URL markers and consolidating the logic into a single helper.

• Removes the hardcoded jscholarshipCheckString and inlined slicing logic
• Adds a formatId method to centralize ID extraction for /handle/ and /items/ URLs
• Updates the external ID mapping to use formatId

Comments suppressed due to low confidence (2)

app/components/submissions-repoid-cell/index.js:56

• Consider adding JSDoc annotations (@param {string} id and @returns {string}) to formatId so callers and IDEs can better understand its expected input and output.

  formatId(id) {

app/components/submissions-repoid-cell/index.js:56

• The new formatId method logic isn't covered by existing tests. Adding unit tests for URLs with /handle/, /items/, and strings without markers would ensure correct behavior.

  formatId(id) {

[rpoet-jh]

Looks good. Are there any tests that cover this code?

[markpatton]

@rpoet-jh
The copilot review made the same comment! Will add.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud