Add a notice about NIHMS submissions on the thanks page#1311
Merged
markpatton merged 3 commits intomainfrom Jul 7, 2025
Merged
Add a notice about NIHMS submissions on the thanks page#1311markpatton merged 3 commits intomainfrom
markpatton merged 3 commits intomainfrom
Conversation
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a notice for NIHMS submissions on the thanks page, introduces a new userGuideUrl config option, switches PMC checks to use repositoryKey, and fixes a flaky icon assertion in an external-repo test.
- Show NIHMS-specific messaging when a submission includes the PMC repository
- Replace FAQ link with a User Guide link driven by new
userGuideUrlconfig - Update PMC checks in both templates and code to use
repositoryKeyinstead ofname - Remove fragile font-awesome glyph assertion in external-repo test
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/components/external-repo-review-test.js | Removed asynchronous FA icon check to stabilize the test |
| app/templates/thanks.hbs | Added NIHMS submission notice inside a loop over submission.repositories and replaced FAQ link with User Guide link |
| app/routes/thanks.js | Injected store service and implemented model hook to include repositories |
| app/controllers/thanks.js | Swapped out faqUrl for the new userGuideUrl from branding config |
| app/components/workflow-files/index.hbs | Changed PMC filtering from repo.name === "PubMed Central" to repo.repositoryKey === "pmc" |
Comments suppressed due to low confidence (2)
app/components/workflow-files/index.hbs:3
- [nitpick] Since the PMC condition was switched to use
repositoryKey, ensure existing tests for this component are updated or new tests are added to cover the 'pmc' key path instead of the previous name-based check.
{{#if (eq repo.repositoryKey "pmc")}}
tests/integration/components/external-repo-review-test.js:26
- [nitpick] The test description may still imply that an error icon should be present, but the assertion was removed. Consider updating the test title or adding alternative assertions to accurately reflect the component's behavior.
);
rpoet-jh
approved these changes
Jul 7, 2025
Contributor
rpoet-jh
left a comment
There was a problem hiding this comment.
Looks good. I tested and saw the new info message on the Thanks page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



userGuideUrlbranding config option which is used on the thanks page.