Skip to content

Fix publication date handling in metadata #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markpatton merged 2 commits into from
Feb 7, 2025
Merged

Fix publication date handling in metadata #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed60185
Make publication date required for JScholarship. Treat properly as a …
markpatton Nov 25, 2024
7040b0a
Remove duplicated metadata schemas from test resources. Update test d…
markpatton Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions pass-core-metadataschema-service/src/main/resources/schemas/jhu/global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,16 @@
},
"publicationDate": {
"type": "date",
"label": "Publication Date <small class=\"text-muted\">(optional)</small>",
"label": "Publication Date <small class=\"text-muted\"></small>",
"hidden": false,
"helpersPosition": "above",
"validate": true,
"inputType": "date",
"fieldClass": "date-time-picker",
"picker": {
"format": "L",
"allowInputToggle": true
},
"order": 8
},
"abstract": {
Expand Down Expand Up @@ -308,12 +316,11 @@
"label": "Embargo End Date",
"helper": "<i>After the embargo end date, your submission manuscripts or article can be made public. <b>If this publication is not under embargo, please leave this field blank.<b></i>",
"helpersPosition": "above",
"placeholder": "dd/mm/yyyy",
"validate": true,
"inputType": "date",
"fieldClass": "date-time-picker",
"picker": {
"format": "MM/DD/YY",
"format": "L",
"allowInputToggle": true
},
"order": 12,
Expand Down
2 changes: 1 addition & 1 deletion pass-core-metadataschema-service/src/main/resources/schemas/jhu/jscholarship.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"$ref": "global.json#/properties/authors"
}
},
"required": ["authors"]
"required": ["authors", "publicationDate"]
},
"options": {
"$ref": "global.json#/options"
Expand Down
55 changes: 0 additions & 55 deletions pass-core-metadataschema-service/src/test/resources/schemas/jhu/common.json
View file
Open in desktop

This file was deleted.

298 changes: 0 additions & 298 deletions pass-core-metadataschema-service/src/test/resources/schemas/jhu/global.json
View file
Open in desktop

This file was deleted.

Loading
Loading