Skip to content

Handle publication date being required #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markpatton merged 2 commits into from
Feb 7, 2025
Merged

Handle publication date being required #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ad9571
Handle publication date being required
markpatton Nov 26, 2024
d081e02
Fix the date entry by typing the text
markpatton Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/baseCaseTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ test('can walk through an nih submission workflow and make a submission - base c
'Quantitative profiling of carbonyl metabolites directly in crude biological extracts using chemoselective tagging and nanoESI-FTMS'
);
await submissionMetadataPage.verifyJournalTitle('The Analyst');
await submissionMetadataPage.inputPublicationDate('05/02/2010');

await submissionMetadataPage.clickNextToFiles();

Expand Down
1 change: 1 addition & 0 deletions tests/journalTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ test('can walk through an submission workflow and make a submission with journal
await submissionMetadataPage.verifyArticleTitle(submissionTitle);
await submissionMetadataPage.verifyJournalTitle('PASS_E2E_TEST_JOURNAL');
await submissionMetadataPage.inputAuthor('PASS_E2E_TEST_AUTHOR');
await submissionMetadataPage.inputPublicationDate('05/02/2010');

await submissionMetadataPage.clickNextToFiles();

Expand Down
1 change: 1 addition & 0 deletions tests/noJournalTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ test('can walk through a submission workflow and make a submission - without sel
await submissionMetadataPage.verifyArticleTitle(submissionTitle);
await submissionMetadataPage.verifyJournalTitle('');
await submissionMetadataPage.inputAuthor('PASS_E2E_TEST_AUTHOR');
await submissionMetadataPage.inputPublicationDate('05/02/2010');
await submissionMetadataPage.clickNextToFiles();

await submissionFilesPage.verifyOAManuscriptsNotExists();
Expand Down
12 changes: 12 additions & 0 deletions tests/page_model/SubmissionMetadata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,18 @@ class SubmissionMetadata {
.typeText(authorInput, authorName, { paste: true, speed: 0.75 });
}

async inputPublicationDate(date) {
const publicationDateInput = Selector('input').withAttribute(
'name',
'publicationDate'
);
await t
.expect(publicationDateInput.exists)
.ok()
.click(publicationDateInput)
.pressKey(date.split('').join(' '));
}

async clickNextToFiles() {
const goToFilesButton = Selector('.alpaca-form-button-Next');
await t.expect(goToFilesButton.exists).ok();
Expand Down
2 changes: 2 additions & 0 deletions tests/proxySubmissionTests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ async function walkThroughSubmissionFlow(t, hasAccount) {
'Quantitative profiling of carbonyl metabolites directly in crude biological extracts using chemoselective tagging and nanoESI-FTMS'
);
await submissionMetadataPage.verifyJournalTitle('The Analyst');
await submissionMetadataPage.inputPublicationDate('05/02/2010');

await submissionMetadataPage.clickNextToFiles();

await submissionFilesPage.verifyOAManuscriptUrl(
Expand Down