feat: add MIFARE Classic support #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `loadKey` to use `KeyStorageType` instead of a boolean. - Modified `generalAuthenticate` to return a boolean result and improved its internal logic for key retrieval and authentication. - Simplified `overview.md` by removing detailed configuration and key management sections.
- Replace `volatileKeyRegistry` and `persistentKeyRegistry` `SparseArray`s with a single `loadedKey` byte array. - Update `loadKey` to store only the most recently provided key. - Update `generalAuthenticate` to use the `loadedKey` (clearing it after use) or fallback to the `keyProvider`. - Ensure `loadedKey` is cleared when the physical channel is opened, closed, or a new tag is discovered.
…roidNfcReaderAdapter
…AndroidNfcReaderAdapter
Specifically, this change: - Replaces the if-else block with a when expression for better readability and safety. - Explicitly handles `MifareClassic`, `MifareUltralight`, and throws an `UnsupportedOperationException` for other technologies. - Removes the explicit 16-byte size check for `MifareClassic` within this method.
- Rename `classic` to `mifareClassic` for clarity in `generalAuthenticate`. - Simplify key retrieval logic using `checkNotNull`. - Stop resetting `loadedKey` to `null` in `onTagDiscovered`.
andrei-cristea
approved these changes
Jan 15, 2026
- Replace the generic `MIFARE_CLASSIC` protocol with specific `MIFARE_CLASSIC_1K` and `MIFARE_CLASSIC_4K` constants. - Update `isProtocolSupported` to validate the physical card size against the requested MIFARE Classic protocol. - Update protocol activation and deactivation logic to handle the new specific MIFARE Classic types.
…isCurrentProtocol Specifically, this change: - Simplifies `isProtocolSupported` to only verify if the protocol name exists. - Moves the MIFARE Classic 1K vs 4K size validation logic to `isCurrentProtocol`. - Updates `CHANGELOG.md` to specify support for `MIFARE_CLASSIC_1K` and `MIFARE_CLASSIC_4K`.
|
andrei-cristea
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.