Clean Code for bundles/org.eclipse.equinox.p2.ui.sdk

[eclipse-equinox-bot]

The following cleanups were applied:

• Add final modifier to private fields
• Add missing '@Deprecated' annotations
• Add missing '@Override' annotations
• Add missing '@Override' annotations to implementations of interface methods
• Convert control statement bodies to block
• Make inner classes static where possible
• Remove trailing white spaces on all lines
• Remove unnecessary array creation for varargs
• Remove unnecessary suppress warning tokens
• Remove unused imports
• Remove unused private constructors
• Remove unused private fields
• Remove unused private methods
• Remove unused private types
• Replace deprecated calls with inlined content where possible
• Use pattern matching for instanceof

The following Manifest cleanups where applied:

• Calculate 'uses' directive for public packages
• Remove unused dependencies

[eclipse-equinox-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.equinox.p2.ui.sdk/META-INF/MANIFEST.MF
features/org.eclipse.equinox.p2.rcp.feature/feature.xml
features/org.eclipse.equinox.p2.sdk/feature.xml
features/org.eclipse.equinox.p2.user.ui/feature.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From b4583a669380aacaa516d4c43c39d10bd3815767 Mon Sep 17 00:00:00 2001
From: Eclipse Equinox Bot <equinox-bot@eclipse.org>
Date: Wed, 4 Mar 2026 04:29:55 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/bundles/org.eclipse.equinox.p2.ui.sdk/META-INF/MANIFEST.MF b/bundles/org.eclipse.equinox.p2.ui.sdk/META-INF/MANIFEST.MF
index 36469593a..8cf424c8e 100644
--- a/bundles/org.eclipse.equinox.p2.ui.sdk/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.equinox.p2.ui.sdk/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %bundleName
 Bundle-SymbolicName: org.eclipse.equinox.p2.ui.sdk;singleton:=true
-Bundle-Version: 1.4.0.qualifier
+Bundle-Version: 1.4.100.qualifier
 Bundle-Activator: org.eclipse.equinox.internal.p2.ui.sdk.ProvSDKUIActivator
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/features/org.eclipse.equinox.p2.rcp.feature/feature.xml b/features/org.eclipse.equinox.p2.rcp.feature/feature.xml
index d2db84556..eaba47d6d 100644
--- a/features/org.eclipse.equinox.p2.rcp.feature/feature.xml
+++ b/features/org.eclipse.equinox.p2.rcp.feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.equinox.p2.rcp.feature"
       label="%featureName"
-      version="1.4.3100.qualifier"
+      version="1.4.3200.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
diff --git a/features/org.eclipse.equinox.p2.sdk/feature.xml b/features/org.eclipse.equinox.p2.sdk/feature.xml
index 047ee1f5b..7784e65dd 100644
--- a/features/org.eclipse.equinox.p2.sdk/feature.xml
+++ b/features/org.eclipse.equinox.p2.sdk/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.equinox.p2.sdk"
       label="%featureName"
-      version="3.11.3100.qualifier"
+      version="3.11.3200.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
diff --git a/features/org.eclipse.equinox.p2.user.ui/feature.xml b/features/org.eclipse.equinox.p2.user.ui/feature.xml
index 5126cab7b..db829b849 100644
--- a/features/org.eclipse.equinox.p2.user.ui/feature.xml
+++ b/features/org.eclipse.equinox.p2.user.ui/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.equinox.p2.user.ui"
       label="%featureName"
-      version="2.4.3100.qualifier"
+      version="2.4.3200.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

[github-actions]

Test Results

   18 files   -   366     18 suites   - 366   29m 43s ⏱️ - 9m 45s
1 907 tests ±    0  1 904 ✅ ±    0  3 💤 ±0  0 ❌ ±0 
5 176 runs   - 1 545  5 167 ✅  - 1 545  9 💤 ±0  0 ❌ ±0 

Results for commit 6e59f5b. ± Comparison against base commit 783265d.

This pull request removes 1785 and adds 1785 tests. Note that renamed tests count towards both.

AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.Bug196525 ‑ testConfigContent
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.Bug258370 ‑ testComma
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testOSGiRemoval
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testSimpleConfiguratorRemoval
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testWithMutipleBundles
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.FrameworkExtensionTest ‑ testAddRemoveFrameworkExtension
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.LauncherConfigLocationTest ‑ testCustomLauncherConfig
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.LauncherDataTest ‑ testRemoveProgramArg
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.ManipulatorTests ‑ testBug212361_osgiInBundlesList
AutomatedTests org.eclipse.equinox.frameworkadmin.tests.AllTests org.eclipse.equinox.frameworkadmin.tests.ManipulatorTests ‑ testBug258126_ProgramArgs_VMArgs
…

org.eclipse.equinox.frameworkadmin.tests.Bug196525 ‑ testConfigContent
org.eclipse.equinox.frameworkadmin.tests.Bug258370 ‑ testComma
org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testOSGiRemoval
org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testSimpleConfiguratorRemoval
org.eclipse.equinox.frameworkadmin.tests.CleanupTest ‑ testWithMutipleBundles
org.eclipse.equinox.frameworkadmin.tests.FrameworkExtensionTest ‑ testAddRemoveFrameworkExtension
org.eclipse.equinox.frameworkadmin.tests.LauncherConfigLocationTest ‑ testCustomLauncherConfig
org.eclipse.equinox.frameworkadmin.tests.LauncherDataTest ‑ testRemoveProgramArg
org.eclipse.equinox.frameworkadmin.tests.ManipulatorTests ‑ testBug212361_osgiInBundlesList
org.eclipse.equinox.frameworkadmin.tests.ManipulatorTests ‑ testBug258126_ProgramArgs_VMArgs
…

This pull request removes 2 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.

AutomatedTests org.eclipse.equinox.p2.tests.ui.dialogs.AllTests org.eclipse.equinox.p2.tests.ui.dialogs.EECompatibilityTest ‑ testEEIssueSkipsRemediation
AutomatedTests org.eclipse.equinox.p2.tests.ui.dialogs.AllTests org.eclipse.equinox.p2.tests.ui.dialogs.EECompatibilityTest ‑ testSingleIUPreventInstallation

org.eclipse.equinox.p2.tests.ui.dialogs.EECompatibilityTest ‑ testEEIssueSkipsRemediation
org.eclipse.equinox.p2.tests.ui.dialogs.EECompatibilityTest ‑ testSingleIUPreventInstallation

♻️ This comment has been updated with latest results.

[laeubi]

PDE has gotten a bugfix so after next i-build we can retry this here.

[akurtakov]

This one seems to be good, no?

[laeubi]

Looks all sane tome me