Clean Code for bundles/org.eclipse.equinox.p2.artifact.repository

bundles/org.eclipse.equinox.p2.artifact.repository/META-INF/MANIFEST.MF

@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.equinox.p2.artifact.repository;singleton:=true
-Bundle-Version: 1.5.800.qualifier
+Bundle-Version: 1.5.900.qualifier
 Bundle-Activator: org.eclipse.equinox.internal.p2.artifact.repository.Activator
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
@@ -39,16 +39,13 @@ Require-Bundle: org.eclipse.equinox.common;bundle-version="[3.18.0,4.0.0)",
  org.tukaani.xz;bundle-version="1.3.0"
 Import-Package: javax.xml.parsers,
  org.bouncycastle.bcpg;version="1.65.0",
- org.bouncycastle.jce.provider;version="1.65.1",
  org.bouncycastle.openpgp;version="1.65.0",
  org.bouncycastle.openpgp.bc;version="1.65.0",
  org.bouncycastle.openpgp.jcajce;version="1.65.0",
  org.bouncycastle.openpgp.operator;version="1.65.0",
  org.bouncycastle.openpgp.operator.bc;version="1.65.0",
- org.bouncycastle.openpgp.operator.jcajce;version="1.65.0",
  org.eclipse.core.runtime.jobs,
  org.eclipse.equinox.internal.p2.core.helpers,
- org.eclipse.equinox.internal.p2.jarprocessor,
  org.eclipse.equinox.internal.p2.metadata,
  org.eclipse.equinox.internal.p2.persistence,
  org.eclipse.equinox.internal.p2.repository,
@@ -61,12 +58,10 @@ Import-Package: javax.xml.parsers,
  org.eclipse.equinox.p2.repository.artifact;version="[2.1.0,3)",
  org.eclipse.equinox.p2.repository.artifact.spi;version="[2.0.0,3.0.0)",
  org.eclipse.equinox.p2.repository.spi;version="[2.0.0,3.0.0)",
- org.eclipse.internal.provisional.equinox.p2.jarprocessor;resolution:=optional,
  org.eclipse.osgi.service.datalocation;version="[1.3.0,2.0.0)",
  org.eclipse.osgi.signedcontent;version="1.0.0",
  org.eclipse.osgi.util;version="1.1.0",
  org.osgi.framework;version="1.3.0",
- org.osgi.service.prefs;version="1.1.1",
  org.w3c.dom,
  org.xml.sax;resolution:=optional
 Service-Component: OSGI-INF/org.eclipse.equinox.internal.p2.artifact.repository.DefaultArtifactManagerServiceFactory.xml,

bundles/org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/processors/md5/MD5Verifier.java

@@ -30,19 +30,23 @@
 @Deprecated
 public class MD5Verifier extends MessageDigestProcessingStep {
 
+	@Deprecated
 	protected String expectedMD5;
 
+	@Deprecated
 	public MD5Verifier() {
 		super();
 	}
 
+	@Deprecated
 	public MD5Verifier(String expected) {
 		super();
 		this.expectedMD5 = expected;
 		basicInitialize(null);
 	}
 
 	//This handle the case where the MD5 verification is initiated by a processing step
+	@Deprecated
 	@Override
 	public void initialize(IProvisioningAgent agent, IProcessingStepDescriptor descriptor, IArtifactDescriptor context) {
 		super.initialize(agent, descriptor, context);
@@ -69,6 +73,7 @@ private void basicInitialize(IProcessingStepDescriptor descriptor) {
 		}
 	}
 
+	@Deprecated
 	@Override
 	protected void onClose(String digestString) {
 		// if the hashes don't line up set the status to error.

bundles/org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/processors/pgp/PGPPublicKeyStore.java

@@ -89,7 +89,6 @@ public static Set<PGPPublicKey> readPublicKeys(InputStream input) throws IOExcep
 		return readPublicKeys(new String(input.readAllBytes(), StandardCharsets.US_ASCII));
 	}
 
-	@SuppressWarnings("unchecked")
 	public static Set<PGPPublicKey> readPublicKeys(String armoredPublicKeyring) {
 		if (armoredPublicKeyring == null) {
 			return Set.of();