Improve handling of array editing#468
Open
eneufeld wants to merge 1 commit intoeclipse-emfcloud:masterfrom
Open
Improve handling of array editing#468eneufeld wants to merge 1 commit intoeclipse-emfcloud:masterfrom
eneufeld wants to merge 1 commit intoeclipse-emfcloud:masterfrom
Conversation
This improves the handling of array editing.
ndoschek
requested changes
Dec 1, 2022
Member
ndoschek
left a comment
ndoschek
left a comment
There was a problem hiding this comment.
Thanks Eugen for the update!
I noticed a problem for the use case of manipulating array elements if there are more than one element in the array.
- deleting the second array element + adding a new one behaves not as expected:
coffee-editor-array-editing.mp4
PS: Also, could you please rebase your branch, somehow it doesn't build locally for me, so i tested it with your branch rebased to latest master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the handling of array editing.