Resolve generics inheritance conflicts and avoid reflection for JavaFX21+#475
Closed
anishthecoder wants to merge 1 commit intoeclipse-efx:3.xfrom
Closed
Resolve generics inheritance conflicts and avoid reflection for JavaFX21+#475anishthecoder wants to merge 1 commit intoeclipse-efx:3.xfrom
anishthecoder wants to merge 1 commit intoeclipse-efx:3.xfrom
Conversation
8f13d3a to
8061c30
Compare
Contributor
|
you need to sign the eca - generally the change looks ok to me |
8061c30 to
35561bd
Compare
Contributor
Author
|
Thanks @tomsontom ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error reported in #469 appears to be from a stricter requirement for resolving multiple inheritance paths for the same default method. This seems to appears when using Java 22 or higher. However, the changes proposed here should be compatible with Java 21 as well.
Tested with Maven 3.9.11 using Java 21 and Java 25.
@tomsontom @martinbluehweis
If this is acceptable, could the Maven repositories be updated with the latest artifacts along with the BOM-style POM file?