Support SSH connections to local VS Code based editors.#2039
Support SSH connections to local VS Code based editors.#2039tolusha merged 1 commit intoeclipse-che:mainfrom
Conversation
azatsarynnyy
left a comment
There was a problem hiding this comment.
I tested the editor definition from the gist, in che-incubator/che-code#560 (review)
|
I've done my testing and I'm pretty satisfied with merging this soon. The only thing to figure out is my comment on che-incubator/che-code#560 (comment) . Getting the default resource values into a reasonable range. |
|
@azatsarynnyy , I don't have anything else to do here for now, so feel free to merge at earliest convenience. |
Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
|
@tolusha could you please review & merge? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: azatsarynnyy, ibuziuk, rgrunber, tolusha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Only additional changes I've made that weren't there, are the addition of
iconData&iconMediaTypeproperties.