Fix extension key and recommend pie install#162
Merged
Conversation
ptondereau
changed the title
divarvel
reviewed
May 9, 2026
| { | ||
| "require": { | ||
| "ext-biscuit-php": "*" | ||
| "ext-biscuit_php": "*" |
Contributor
There was a problem hiding this comment.
the mixed kebab/snake case is surprising. is this required by pie?
Contributor
Author
There was a problem hiding this comment.
Yes this because the old CLI pecl support only underscore as a separator, so pie decided to have the same behavior
Contributor
Author
There was a problem hiding this comment.
divarvel
reviewed
May 9, 2026
ptondereau
force-pushed
the
docs/php-install-fixes
branch
from
5e6cae8 to
f01350d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ext-biscuit-php→ext-biscuit_php(matches the actual extension name)pie install ptondereau/biscuit-phpas the preferred install methodptondereau/biscuit-sf-bundle