Update to support Datalog version 3.3. #137
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting on behalf of @saoirse-a
Adds support for Datalog features from Biscuit 3.3 except for FFI, which are:
===and!==||and&&compile toLazyAnd/LazyOrRefactors
Op.ValueandExpression.Valueare eliminated, insteadTerminherits fromOpandExpression, saving an indirection/allocation.SchemaVersionrefactored (and duplicate implementation ofSchemaVersioneliminated) to be clearer and avoid an unnecessary allocation.Test changes
SamplesTest changed to deal with the additional complexities that maps bring. Most importantly, we cannot rely on a byte-for-byte comparison of the generated datalog block with the sample, because maps do not have a canonical order among their members. Instead we rely on the serialise / deserialise step to check roundtrips and add a check that we are generated the same version number for blocks (which is the only other thing I saw caught by these assertions).