Ensure Biscuit Builder Runs Rule Validation #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e original rule head with a placeholder predicate. Add an API that validates the Rule before including it in the biscuit.
preuss-adam
force-pushed
the
apreuss/builder-rule-validation
branch
from
e30ab1c to
b10557a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that check queries have a consistent structure by replacing the original rule head with a placeholder predicate.
Without this fix, if a rule has a malformed head (e.g., the head predicate does not include all the variables in the body) the biscuit builder does not report any errors, but the authorizer catches the issue.
Also adds an
addRule()API that optionally validates the rule.