adapter.aasx: Add support for loading/saving thumbnails in AASX package #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackage Previously, the `AASXReader` did not load the thumbnail in the `read_into` function, instead a separate function needed to be called. This behavior did also occur in `AASXWriter` with writing the thumbnail. This was unintuitive, as it required a separat call of the load/save function. This PR implements the loading/storing of the thumbnail directly in the loading/storing of other supplementary files. Fixes eclipse-basyx#435
s-heppner
requested changes
Dec 2, 2025
s-heppner
reviewed
Dec 2, 2025
s-heppner
reviewed
Dec 2, 2025
Contributor
|
I took the liberty to add some small changes. Could you please fix the remaining issues? The |
zrgt
reviewed
Dec 10, 2025
zrgt
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
AASXReaderdid not load the thumbnail in theread_intofunction, instead a separate function needed to be called. This behavior did also occur inAASXWriterwith writing the thumbnail. This was unintuitive, as it required a separat call of the load/save function.This PR implements the loading/storing of the thumbnail directly in the loading/storing of other supplementary files.
Fixes #435