Open
Conversation
Change pdftotext check from single path to environment PATH variable to better support for non-default installs. Add XPDF to path check to support Windows install of the XPDF port of pdftotext.
Move saved_file path creation outside loop. Only needs to happen once. Change from replace to fix issues on some systems where capitalized extensions cause overwriting of the read file with the saved_file. Wrap file operation in with statement to fix single page blank pdf from retaining file lock on saved_file
Add behavior for not prepending pagenumbers to each page. Add options arg to allow passing options to pdftotext call
Change the check to look a little saner. If: pass else: dostuff hurts my brain a little.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the check to be OS independent. Fixed a bug in the saved_file creation occasionally caused by capitalized extensions. Fixed a file lock problem caused by blank one page pdfs. Added the page num False behavior as a bulk load as there was little value in iterating over pages when not inserting page numbers.